Measure the usage of navigator.vibrate in for user gesture & subframe.

third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

 /*
  *  Copyright (C) 2012 Samsung Electronics
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Library General Public
  *  License as published by the Free Software Foundation; either
  *  version 2 of the License, or (at your option) any later version.
  *
  *  This library is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
  *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  *  Library General Public License for more details.
  *
  *  You should have received a copy of the GNU Library General Public License
  *  along with this library; see the file COPYING.LIB.  If not, write to
  *  the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  *  Boston, MA 02110-1301, USA.
  */
 
 #include "modules/vibration/NavigatorVibration.h"
 
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Navigator.h"
 #include "core/frame/UseCounter.h"
 #include "core/page/Page.h"
 #include "modules/vibration/VibrationController.h"
+#include "platform/Histogram.h"
+#include "platform/UserGestureIndicator.h"
 
 namespace blink {
 
 NavigatorVibration::NavigatorVibration(Navigator& navigator)
     : DOMWindowProperty(navigator.frame())
 {
 }
 
 NavigatorVibration::~NavigatorVibration()
 {
@@ skipping 37 matching lines @@
     UseCounter::count(frame, UseCounter::NavigatorVibrate);
     if (!frame->isMainFrame())
         UseCounter::count(frame, UseCounter::NavigatorVibrateSubFrame);
 
     DCHECK(frame->document());
     DCHECK(frame->page());
 
     if (!frame->page()->isPageVisible())
         return false;
 
+    if (frame->isCrossOrigin()) {

[Michael van Ouwerkerk, 2016/06/20 13:00:01]

Recording whether a user gesture is present would also be useful if it's not
cross origin.

+        DEFINE_STATIC_LOCAL(EnumerationHistogram, crossOriginVibrateHistogram, ("WebModules.CrossOriginVibrate", 2));
+        crossOriginVibrateHistogram.count(UserGestureIndicator::processingUserGesture() ? 1 : 0);

[Michael van Ouwerkerk, 2016/06/20 13:00:01]

To make the data consistent with the use counters above, this should all go
before the early return for page visibility.

+    }

[mlamouri (slow - plz ping), 2016/06/20 10:39:20]

Would that make sense to integrate with the NavigatorVibrate and
NavigatorVibrateSubFrame above? FWIW, NavigatorVibrateSubFrame already has a
very low value. The issue here is that vibrate is abused a lot on mobile with
popups (so they are top frames).

[ojan, 2016/06/20 14:04:09]

I didn't realize we had NavigatorVibrateSubFrame already.

Looking at our internal numbers, ~0.16% of android page views use
NavigatorVibrate and ~0.0064% hit NavigatorVibrateSubFrame. I suspect a large
percentage of the latter are ads that are user annoyance.

IMO, we don't need more numbers. We should put together an intent to implement
and ship to disable vibrate inside cross origin frames. The intent should
clarify that we'll allow it again in the future once we figure out the shape of
the permissions API.
Ugh. That's something we'll need to solve in a different way I think. I think
changing cross-origin frames to disallow vibrate by default is still a valuable
change though, yeah?

+
     return NavigatorVibration::from(navigator).controller()->vibrate(pattern);
 }
 
 VibrationController* NavigatorVibration::controller()
 {
     if (!m_controller && frame())
         m_controller = new VibrationController(*frame()->document());
 
     return m_controller.get();
 }
 
 void NavigatorVibration::willDetachGlobalObjectFromFrame()
 {
     if (m_controller) {
         m_controller->cancel();
         m_controller = nullptr;
     }
 }
 
 DEFINE_TRACE(NavigatorVibration)
 {
     visitor->trace(m_controller);
     Supplement<Navigator>::trace(visitor);
     DOMWindowProperty::trace(visitor);
 }
 
 } // namespace blink