Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: remoting/android/remoting_apk_tmpl.gni

Issue 2082453003: 🎅 Use GN's dependency info for native libraries in write_build_config.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix osmesa on non-android Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/remoting_apk_tmpl.gni
diff --git a/remoting/android/remoting_apk_tmpl.gni b/remoting/android/remoting_apk_tmpl.gni
index db9d24d7e17000cd268ac1f8073493f7392197fb..6c22102e8901a94e6b415b79e64dbac0ccdab072 100644
--- a/remoting/android/remoting_apk_tmpl.gni
+++ b/remoting/android/remoting_apk_tmpl.gni
@@ -10,12 +10,9 @@ template("remoting_apk_tmpl") {
forward_variables_from(invoker, "*")
android_manifest = "$root_gen_dir/remoting/android/AndroidManifest.xml"
- native_libs = [ "libremoting_client_jni.so" ]
+ shared_libraries = [ "//remoting/android:remoting_client_jni" ]
- deps += [
- "//remoting/android:remoting_apk_manifest",
- "//remoting/android:remoting_client_jni",
- ]
+ deps += [ "//remoting/android:remoting_apk_manifest" ]
if (remoting_enable_cardboard && current_cpu == "arm") {
deps += [ "//remoting/android:remoting_cardboard_extract_native_lib" ]

Powered by Google App Engine
This is Rietveld 408576698