Move SwapOut methods to RenderFrameHost.

Move SwapOut methods to RenderFrameHost.

This leaves the state in RenderViewHost for now, to make this an easier
first step.

BUG=304341
TEST=No behavior change.
R=nasko@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260155

[Charlie Reis, 2014-03-24 22:17:49]

Nasko: Can you take a look?  I could use some careful eyes on the method bodies
that moved from RenderView{Host} to RenderFrame{Host}.  Thanks!

https://codereview.chromium.org/208243019/diff/1/content/browser/frame_host/r...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/208243019/diff/1/content/browser/frame_host/r...
content/browser/frame_host/render_frame_host_manager.cc:364: // Sanity check
that this is for the correct frame.
This is borrowed from https://codereview.chromium.org/209153003/, which I expect
to land first.

https://codereview.chromium.org/208243019/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_impl.cc (left):

https://codereview.chromium.org/208243019/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_impl.cc:3026:
GetRenderManager()->SwappedOut(rvh);
I moved this line into RFHI::SwapOut.

[nasko, 2014-03-25 18:15:18]

Wow! Exciting! With just one nit, LGTM!

https://codereview.chromium.org/208243019/diff/20001/content/renderer/render_...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/208243019/diff/20001/content/renderer/render_...
content/renderer/render_frame_impl.cc:805: // support unload on subframes as
well.
nit: The comment seems to imply that we will be adding another call to the
existing one. Aren't we going to replace the WebView call with the WebFrame
call?

[Charlie Reis, 2014-03-28 15:55:18]

Thanks!  Can you take one more look at RenderFrameHostImpl::SwapOut() now that
I've merged to pick up your recent change?  I also fixed a check that failed in
the transfer tests.

https://codereview.chromium.org/208243019/diff/20001/content/renderer/render_...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/208243019/diff/20001/content/renderer/render_...
content/renderer/render_frame_impl.cc:805: // support unload on subframes as
well.
On 2014/03/25 18:15:18, nasko wrote:
> nit: The comment seems to imply that we will be adding another call to the
> existing one. Aren't we going to replace the WebView call with the WebFrame
> call?

Yes, that's more accurate.  Done.

https://codereview.chromium.org/208243019/diff/100001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/208243019/diff/100001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_manager.cc:364: // Sanity check
that the params are for the correct frame and process.
I needed to update these checks to handle the various transfer cases.  It
mattered whether we had started a cross-process navigation before the transfer
or not.

[nasko, 2014-03-28 16:10:48]

LGTM again. Just one nit.

https://codereview.chromium.org/208243019/diff/100001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/208243019/diff/100001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_manager.cc:369: int frame_id =
pending_render_frame_host_ ?
nit: render_frame_id?

[Charlie Reis, 2014-03-28 16:18:04]

Thanks!  Try jobs from patch 4 look good, so I'll land manually.

https://codereview.chromium.org/208243019/diff/100001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/208243019/diff/100001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_manager.cc:369: int frame_id =
pending_render_frame_host_ ?
On 2014/03/28 16:10:48, nasko wrote:
> nit: render_frame_id?

Done.

[Charlie Reis, 2014-03-28 16:26:01]

Committed patchset #6 manually as r260155 (presubmit successful).