Add sysexEnabled readonly attribute to MIDIAccess

Add sysexEnabled readonly attribute to MIDIAccess

To conform the latest W3C spec, add sysexEnabled attribute.
http://www.w3.org/TR/webmidi/#idl-def-MIDIAccess

MIDIAccess originally has a method sysExEnabled().
To avoid having two functions for the same operation, this change
renames it to sysexEnabled(). This change affects other caller
implementations.

To rename everything in blink, it modifies blink API.
So this change is also the first step of blink API change.

Here are a series of changes.
1. this change
2. https://codereview.chromium.org/210003002/
3. https://codereview.chromium.org/208423016/

BUG=349538
TEST=LayoutTests/webmidi

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169909

[Takashi Toyoshima, 2014-03-24 11:38:10]

Hi, can you review this change?

Kent:
I updated MIDIAccess.idl which affects web facing attributes. Can you take a
look it as an API owner? Also, please take a look on caller side minor changes
on web/.

Kouhei:
Can you review this as a Web MIDI owner?

https://codereview.chromium.org/208243014/diff/1/LayoutTests/webmidi/permissi...
File LayoutTests/webmidi/permission.html (right):

https://codereview.chromium.org/208243014/diff/1/LayoutTests/webmidi/permissi...
LayoutTests/webmidi/permission.html:45: access = a;
Make |access| global to be available from shouldBe().

https://codereview.chromium.org/208243014/diff/1/Source/modules/webmidi/MIDIA...
File Source/modules/webmidi/MIDIAccess.h (right):

https://codereview.chromium.org/208243014/diff/1/Source/modules/webmidi/MIDIA...
Source/modules/webmidi/MIDIAccess.h:68: bool sysexEnabled() const { return
m_sysexEnabled; }
s/sysEx/sysex/ in MIDIAccess. I'm not sure we should apply the same renaming on
everything in blink. WDYT?

[tkent, 2014-03-24 11:52:38]

lgtm

https://codereview.chromium.org/208243014/diff/1/LayoutTests/webmidi/permissi...
File LayoutTests/webmidi/permission.html (right):

https://codereview.chromium.org/208243014/diff/1/LayoutTests/webmidi/permissi...
LayoutTests/webmidi/permission.html:48: shouldBe("access.sysexEnabled", "true");
shouldBe -> shouldBeTrue

https://codereview.chromium.org/208243014/diff/1/LayoutTests/webmidi/requestm...
File LayoutTests/webmidi/requestmidiaccess.html (right):

https://codereview.chromium.org/208243014/diff/1/LayoutTests/webmidi/requestm...
LayoutTests/webmidi/requestmidiaccess.html:23: shouldBe("access.sysexEnabled",
"false");
Use shouldBeFalse.

https://codereview.chromium.org/208243014/diff/1/Source/modules/webmidi/MIDIA...
File Source/modules/webmidi/MIDIAccess.h (right):

https://codereview.chromium.org/208243014/diff/1/Source/modules/webmidi/MIDIA...
Source/modules/webmidi/MIDIAccess.h:68: bool sysexEnabled() const { return
m_sysexEnabled; }
On 2014/03/24 11:38:10, Takashi Toyoshima (chromium) wrote:
> s/sysEx/sysex/ in MIDIAccess. I'm not sure we should apply the same renaming
on
> everything in blink. WDYT?

It's up to you.
I prefer renaming everything for consistency with the IDL.

[Takashi Toyoshima, 2014-03-24 13:52:09]

Done.
I changed all functions in blink, and it contains three Blink APIs.
Now that it needs three step API update, I upload other two steps as described
in the change description.

[tkent, 2014-03-24 13:57:35]

lgtm

https://codereview.chromium.org/208243014/diff/40001/LayoutTests/webmidi/perm...
File LayoutTests/webmidi/permission.html (right):

https://codereview.chromium.org/208243014/diff/40001/LayoutTests/webmidi/perm...
LayoutTests/webmidi/permission.html:13: testRunner.setMIDISysexPermission =
testRunner.setMIDISysExPermission;
nit: We use four spaces indentation.

https://codereview.chromium.org/208243014/diff/40001/LayoutTests/webmidi/send...
File LayoutTests/webmidi/send_messages.html (right):

https://codereview.chromium.org/208243014/diff/40001/LayoutTests/webmidi/send...
LayoutTests/webmidi/send_messages.html:13: testRunner.setMIDISysexPermission =
testRunner.setMIDISysExPermission;
nit: We use four spaces indentation.

[Takashi Toyoshima, 2014-03-24 14:36:00]

Oops, sorry for my poor nits. I failed to switch editor configurations :(

https://codereview.chromium.org/208243014/diff/40001/LayoutTests/webmidi/perm...
File LayoutTests/webmidi/permission.html (right):

https://codereview.chromium.org/208243014/diff/40001/LayoutTests/webmidi/perm...
LayoutTests/webmidi/permission.html:13: testRunner.setMIDISysexPermission =
testRunner.setMIDISysExPermission;
On 2014/03/24 13:57:36, tkent wrote:
> nit: We use four spaces indentation.

Done.

https://codereview.chromium.org/208243014/diff/40001/LayoutTests/webmidi/send...
File LayoutTests/webmidi/send_messages.html (right):

https://codereview.chromium.org/208243014/diff/40001/LayoutTests/webmidi/send...
LayoutTests/webmidi/send_messages.html:13: testRunner.setMIDISysexPermission =
testRunner.setMIDISysExPermission;
On 2014/03/24 13:57:36, tkent wrote:
> nit: We use four spaces indentation.

Done.

[kouhei (in TOK), 2014-03-25 00:23:02]

lgtm

https://codereview.chromium.org/208243014/diff/60001/LayoutTests/webmidi/perm...
File LayoutTests/webmidi/permission.html (right):

https://codereview.chromium.org/208243014/diff/60001/LayoutTests/webmidi/perm...
LayoutTests/webmidi/permission.html:47: promise.then(function(a) {
Optional Nit: a => obtainedAccess or something readable.

[Takashi Toyoshima, 2014-03-25 04:08:38]

Thanks!

https://codereview.chromium.org/208243014/diff/60001/LayoutTests/webmidi/perm...
File LayoutTests/webmidi/permission.html (right):

https://codereview.chromium.org/208243014/diff/60001/LayoutTests/webmidi/perm...
LayoutTests/webmidi/permission.html:47: promise.then(function(a) {
On 2014/03/25 00:23:02, kouhei wrote:
> Optional Nit: a => obtainedAccess or something readable.

Done.

[Takashi Toyoshima, 2014-03-25 04:08:44]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2014-03-25 04:08:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/208243014/80001

[commit-bot: I haz the power, 2014-03-25 04:43:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 04:43:56]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[Takashi Toyoshima, 2014-03-25 04:46:24]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2014-03-25 04:46:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/208243014/80001

[commit-bot: I haz the power, 2014-03-25 05:22:28]

Change committed as 169909