Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 208243003: rebaseline_server: rename results.py to compare_to_expectations.py (Closed)

Created:
6 years, 9 months ago by epoger
Modified:
6 years, 9 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: rename results.py to compare_to_expectations.py BUG=skia:1919 NOTREECHECKS=True NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=13894

Patch Set 1 #

Patch Set 2 : delete extra file #

Total comments: 3

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1164 lines) Patch
A + gm/rebaseline_server/compare_to_expectations.py View 11 chunks +52 lines, -76 lines 0 comments Download
A + gm/rebaseline_server/compare_to_expectations_test.py View 3 chunks +5 lines, -4 lines 0 comments Download
M gm/rebaseline_server/results.py View 3 chunks +0 lines, -463 lines 0 comments Download
D gm/rebaseline_server/results_test.py View 1 chunk +0 lines, -56 lines 0 comments Download
M gm/rebaseline_server/server.py View 1 2 4 chunks +5 lines, -4 lines 0 comments Download
A + gm/rebaseline_server/testdata/outputs/expected/compare_to_expectations_test.CompareToExpectationsTest.test_gm/gm.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D gm/rebaseline_server/testdata/outputs/expected/results_test.ResultsTest.test_gm/gm.json View 1 chunk +0 lines, -562 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
epoger
Ready for review at patchset 2. https://codereview.chromium.org/208243003/diff/20001/gm/rebaseline_server/compare_to_expectations.py File gm/rebaseline_server/compare_to_expectations.py (right): https://codereview.chromium.org/208243003/diff/20001/gm/rebaseline_server/compare_to_expectations.py#newcode2 gm/rebaseline_server/compare_to_expectations.py:2: Reason for the ...
6 years, 9 months ago (2014-03-21 15:09:05 UTC) #1
borenet
LGTM. This was far less scary than it initially appeared.
6 years, 9 months ago (2014-03-21 17:17:38 UTC) #2
epoger
The CQ bit was checked by epoger@google.com
6 years, 9 months ago (2014-03-21 17:28:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/208243003/20001
6 years, 9 months ago (2014-03-21 17:28:26 UTC) #4
epoger
The CQ bit was unchecked by epoger@google.com
6 years, 9 months ago (2014-03-21 17:28:56 UTC) #5
epoger
The CQ bit was checked by epoger@google.com
6 years, 9 months ago (2014-03-21 17:53:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/208243003/40001
6 years, 9 months ago (2014-03-21 17:53:58 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 17:54:20 UTC) #8
Message was sent while issue was closed.
Change committed as 13894

Powered by Google App Engine
This is Rietveld 408576698