Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2082423002: Add guards around access to font cache global fields. (Closed)

Created:
4 years, 6 months ago by herb_g
Modified:
4 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, Alexander Potapenko
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add guards around access to font cache global fields. BUG=589439 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2082423002 Committed: https://skia.googlesource.com/skia/+/632d004677de66a985d05c25a25e25272c740ede

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M src/core/SkGlyphCache.cpp View 2 chunks +20 lines, -0 lines 0 comments Download
M src/core/SkGlyphCache_Globals.h View 2 chunks +5 lines, -12 lines 1 comment Download

Messages

Total messages: 15 (8 generated)
herb_g
This is an attempt to fix the long standing bug in chrome. This is actually ...
4 years, 6 months ago (2016-06-22 15:42:36 UTC) #4
mtklein
lgtm
4 years, 6 months ago (2016-06-22 15:45:42 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082423002/1
4 years, 6 months ago (2016-06-22 15:51:04 UTC) #7
reed1
https://codereview.chromium.org/2082423002/diff/1/src/core/SkGlyphCache_Globals.h File src/core/SkGlyphCache_Globals.h (right): https://codereview.chromium.org/2082423002/diff/1/src/core/SkGlyphCache_Globals.h#newcode45 src/core/SkGlyphCache_Globals.h:45: mutable SkSpinlock fLock; make private?
4 years, 6 months ago (2016-06-22 16:05:36 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 16:08:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082423002/1
4 years, 6 months ago (2016-06-22 17:18:22 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 17:19:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/632d004677de66a985d05c25a25e25272c740ede

Powered by Google App Engine
This is Rietveld 408576698