Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2082403002: Change GroupName test to https. (Closed)

Created:
4 years, 6 months ago by Bence
Modified:
4 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change GroupName test to https. Alternative Services for insecure origins have been disabled in https://crbug.com/615497, making HttpNetworkTransactionTest.GroupNameFor* tests unrealistic. This CL changes these tests to use a secure origin instead. The alternative service port is changed to ensure that group name has port of origin, not of alternative service. BUG=615413 Committed: https://crrev.com/aa60ff405b46620f283640f1f6571670b65d8fe8 Cr-Commit-Position: refs/heads/master@{#401380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M net/http/http_network_transaction_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 6 months ago (2016-06-22 16:15:27 UTC) #2
Ryan Hamilton
lgtm
4 years, 6 months ago (2016-06-22 17:54:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082403002/1
4 years, 6 months ago (2016-06-22 19:07:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 19:12:59 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 19:14:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa60ff405b46620f283640f1f6571670b65d8fe8
Cr-Commit-Position: refs/heads/master@{#401380}

Powered by Google App Engine
This is Rietveld 408576698