Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4986)

Unified Diff: chrome/test/chromedriver/test_environment.py

Issue 20824008: Reland r212020: Move Python setup/tear down logic into Forwarder ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Close unused FDs Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/run_py_tests.py ('k') | tools/telemetry/telemetry/core/chrome/adb_commands.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/test_environment.py
diff --git a/chrome/test/chromedriver/test_environment.py b/chrome/test/chromedriver/test_environment.py
index ebcbd0f152b95b1942d3a986570135f6ff5ff00f..2344ad3a79ade0589d8b61c128c5fa6779cd54ca 100644
--- a/chrome/test/chromedriver/test_environment.py
+++ b/chrome/test/chromedriver/test_environment.py
@@ -94,19 +94,14 @@ class AndroidTestEnvironment(DesktopTestEnvironment):
os.putenv('TEST_HTTP_PORT', str(ANDROID_TEST_HTTP_PORT))
os.putenv('TEST_HTTPS_PORT', str(ANDROID_TEST_HTTPS_PORT))
self._adb = android_commands.AndroidCommands()
- forwarder.Forwarder.KillHost('Debug')
- self._forwarder = forwarder.Forwarder(self._adb, 'Debug')
- self._forwarder.Run(
+ forwarder.Forwarder.Map(
[(ANDROID_TEST_HTTP_PORT, ANDROID_TEST_HTTP_PORT),
(ANDROID_TEST_HTTPS_PORT, ANDROID_TEST_HTTPS_PORT)],
- valgrind_tools.BaseTool())
+ self._adb)
# override
def GlobalTearDown(self):
- if self._adb is not None:
- forwarder.Forwarder.KillDevice(self._adb, valgrind_tools.BaseTool())
- if self._forwarder is not None:
- self._forwarder.Close()
+ forwarder.Forwarder.UnmapAllDevicePorts(self._adb)
# override
def GetOS(self):
« no previous file with comments | « chrome/test/chromedriver/run_py_tests.py ('k') | tools/telemetry/telemetry/core/chrome/adb_commands.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698