Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 20824007: Fixing infobars apis docs which was introduced by https://chromiumcodereview.appspot.com/20081002 (Closed)

Created:
7 years, 4 months ago by pals
Modified:
7 years, 4 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 1

Patch Set 2 : FIxed the docs for infobars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
D chrome/common/extensions/docs/templates/intros/infobars.html View 1 1 chunk +47 lines, -1 line 0 comments Download
A + chrome/common/extensions/docs/templates/public/extensions/infobars.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pals
Did a mistake while rebasing the last patch. This fixes the API docs for infobars. ...
7 years, 4 months ago (2013-08-01 11:04:12 UTC) #1
方觉(Fang Jue)
https://chromiumcodereview.appspot.com/20824007/diff/3001/chrome/common/extensions/docs/templates/intros/infobars.html File chrome/common/extensions/docs/templates/intros/infobars.html (left): https://chromiumcodereview.appspot.com/20824007/diff/3001/chrome/common/extensions/docs/templates/intros/infobars.html#oldcode1 chrome/common/extensions/docs/templates/intros/infobars.html:1: {{+partials.standard_extensions_api api:apis.infobars intro:intros.infobars}} You probably want to copy the ...
7 years, 4 months ago (2013-08-01 13:53:15 UTC) #2
pals
On 2013/08/01 13:53:15, 方觉(Fang Jue) wrote: > https://chromiumcodereview.appspot.com/20824007/diff/3001/chrome/common/extensions/docs/templates/intros/infobars.html > File chrome/common/extensions/docs/templates/intros/infobars.html (left): > > https://chromiumcodereview.appspot.com/20824007/diff/3001/chrome/common/extensions/docs/templates/intros/infobars.html#oldcode1 ...
7 years, 4 months ago (2013-08-01 14:17:23 UTC) #3
Matt Perry
This is not correct. See my latest comments on your original change: https://codereview.chromium.org/20081002/ Also, please ...
7 years, 4 months ago (2013-08-01 18:47:23 UTC) #4
pals
On 2013/08/01 18:47:23, Matt Perry wrote: > This is not correct. See my latest comments ...
7 years, 4 months ago (2013-08-02 06:26:30 UTC) #5
Matt Perry
lgtm
7 years, 4 months ago (2013-08-02 19:36:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/20824007/14001
7 years, 4 months ago (2013-08-03 17:31:18 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-03 20:05:16 UTC) #8
Message was sent while issue was closed.
Change committed as 215513

Powered by Google App Engine
This is Rietveld 408576698