Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2082363002: Remove calls to deprecated MessageLoop methods in remoting. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
Sergey Ulanov, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in remoting. This CL makes the following replacements in remoting: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 R=garykac@chromium.org Committed: https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae Cr-Commit-Position: refs/heads/master@{#401392}

Patch Set 1 #

Total comments: 3

Patch Set 2 : manual change #

Patch Set 3 : add missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -73 lines) Patch
M remoting/base/auto_thread.cc View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/base/auto_thread_task_runner_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M remoting/base/auto_thread_unittest.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M remoting/client/client_status_logger_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M remoting/host/daemon_process_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M remoting/host/host_change_notification_listener_unittest.cc View 6 chunks +17 lines, -15 lines 0 comments Download
M remoting/host/host_status_logger_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M remoting/host/resizing_host_observer_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M remoting/host/setup/start_host_main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/token_validator_factory_impl_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M remoting/protocol/authenticator_test_base.cc View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/protocol/chromium_socket_factory_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/protocol/pseudotcp_adapter_unittest.cc View 1 2 10 chunks +24 lines, -24 lines 0 comments Download
M remoting/protocol/spake2_authenticator_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M remoting/protocol/third_party_authenticator_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/protocol/v2_authenticator_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/signaling/iq_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 15:44:14 UTC) #1
Sergey Ulanov
lgtm https://codereview.chromium.org/2082363002/diff/1/remoting/protocol/pseudotcp_adapter_unittest.cc File remoting/protocol/pseudotcp_adapter_unittest.cc (right): https://codereview.chromium.org/2082363002/diff/1/remoting/protocol/pseudotcp_adapter_unittest.cc#newcode159 remoting/protocol/pseudotcp_adapter_unittest.cc:159: TCPChannelTester(base::MessageLoop* message_loop, nit: this can be replaced with ...
4 years, 6 months ago (2016-06-22 17:50:15 UTC) #3
fdoray
https://codereview.chromium.org/2082363002/diff/1/remoting/protocol/pseudotcp_adapter_unittest.cc File remoting/protocol/pseudotcp_adapter_unittest.cc (right): https://codereview.chromium.org/2082363002/diff/1/remoting/protocol/pseudotcp_adapter_unittest.cc#newcode159 remoting/protocol/pseudotcp_adapter_unittest.cc:159: TCPChannelTester(base::MessageLoop* message_loop, On 2016/06/22 17:50:15, Sergey Ulanov wrote: > ...
4 years, 6 months ago (2016-06-22 18:12:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082363002/40001
4 years, 6 months ago (2016-06-22 18:13:38 UTC) #7
Sergey Ulanov
https://codereview.chromium.org/2082363002/diff/1/remoting/protocol/pseudotcp_adapter_unittest.cc File remoting/protocol/pseudotcp_adapter_unittest.cc (right): https://codereview.chromium.org/2082363002/diff/1/remoting/protocol/pseudotcp_adapter_unittest.cc#newcode159 remoting/protocol/pseudotcp_adapter_unittest.cc:159: TCPChannelTester(base::MessageLoop* message_loop, On 2016/06/22 18:12:48, fdoray wrote: > On ...
4 years, 6 months ago (2016-06-22 18:35:22 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-22 20:36:48 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 20:39:24 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2ad58be9c95de52a6e6962c83df9099c8084ddae
Cr-Commit-Position: refs/heads/master@{#401392}

Powered by Google App Engine
This is Rietveld 408576698