Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2082353002: Remove calls to deprecated MessageLoop methods in jingle. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in jingle. This CL makes the following replacements in jingle: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 R=sergeyu@chromium.org Committed: https://crrev.com/83f4a1ae815486cc99b983f4b38191da96b71c8e Cr-Commit-Position: refs/heads/master@{#401400}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use ThreadTaskRunnerHandle #

Total comments: 2

Patch Set 3 : use ThreadTaskRunnerHandle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -57 lines) Patch
M jingle/glue/chrome_async_socket.cc View 1 5 chunks +11 lines, -23 lines 0 comments Download
M jingle/glue/proxy_resolving_client_socket_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M jingle/glue/task_pump.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M jingle/glue/thread_wrapper_unittest.cc View 8 chunks +15 lines, -13 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M jingle/notifier/listener/non_blocking_push_client_unittest.cc View 8 chunks +11 lines, -10 lines 0 comments Download
M jingle/notifier/listener/push_client_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 15:41:13 UTC) #1
Sergey Ulanov
https://codereview.chromium.org/2082353002/diff/1/jingle/glue/chrome_async_socket.cc File jingle/glue/chrome_async_socket.cc (right): https://codereview.chromium.org/2082353002/diff/1/jingle/glue/chrome_async_socket.cc#newcode123 jingle/glue/chrome_async_socket.cc:123: message_loop->task_runner()->PostTask( Shouldn't this be ThreadTaskRunnerHandle::get()->PostTask?
4 years, 6 months ago (2016-06-22 17:42:29 UTC) #2
fdoray
PTAnL https://codereview.chromium.org/2082353002/diff/1/jingle/glue/chrome_async_socket.cc File jingle/glue/chrome_async_socket.cc (right): https://codereview.chromium.org/2082353002/diff/1/jingle/glue/chrome_async_socket.cc#newcode123 jingle/glue/chrome_async_socket.cc:123: message_loop->task_runner()->PostTask( On 2016/06/22 17:42:29, Sergey Ulanov wrote: > ...
4 years, 6 months ago (2016-06-22 17:48:06 UTC) #3
Sergey Ulanov
LGTM when my comment is addressed https://codereview.chromium.org/2082353002/diff/20001/jingle/glue/task_pump.cc File jingle/glue/task_pump.cc (right): https://codereview.chromium.org/2082353002/diff/20001/jingle/glue/task_pump.cc#newcode30 jingle/glue/task_pump.cc:30: current_message_loop->task_runner()->PostTask( ThreadTaskRunnerHandle::Get() here ...
4 years, 6 months ago (2016-06-22 17:52:15 UTC) #4
fdoray
https://codereview.chromium.org/2082353002/diff/20001/jingle/glue/task_pump.cc File jingle/glue/task_pump.cc (right): https://codereview.chromium.org/2082353002/diff/20001/jingle/glue/task_pump.cc#newcode30 jingle/glue/task_pump.cc:30: current_message_loop->task_runner()->PostTask( On 2016/06/22 17:52:15, Sergey Ulanov wrote: > ThreadTaskRunnerHandle::Get() ...
4 years, 6 months ago (2016-06-22 18:15:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082353002/40001
4 years, 6 months ago (2016-06-22 18:16:28 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-22 21:06:02 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 21:11:45 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/83f4a1ae815486cc99b983f4b38191da96b71c8e
Cr-Commit-Position: refs/heads/master@{#401400}

Powered by Google App Engine
This is Rietveld 408576698