Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: content/browser/loader/resource_dispatcher_host_unittest.cc

Issue 2082343002: Remove calls to deprecated MessageLoop methods in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_unittest.cc
diff --git a/content/browser/loader/resource_dispatcher_host_unittest.cc b/content/browser/loader/resource_dispatcher_host_unittest.cc
index 629afb9e59db72f8d4639bef079653844a29581b..492cbb42d93ec4e2d502d26903d9f17fe54217c1 100644
--- a/content/browser/loader/resource_dispatcher_host_unittest.cc
+++ b/content/browser/loader/resource_dispatcher_host_unittest.cc
@@ -1565,7 +1565,7 @@ TEST_P(ResourceDispatcherHostTest, DetachedResourceTimesOut) {
base::OneShotTimer timer;
timer.Start(FROM_HERE, base::TimeDelta::FromMilliseconds(210),
base::MessageLoop::current(), &base::MessageLoop::QuitWhenIdle);
ncarter (slow) 2016/06/22 20:51:09 It seems inconsistent to update the Run() semantic
- base::MessageLoop::current()->Run();
+ base::RunLoop().Run();
// The prefetch should be cancelled by now.
EXPECT_EQ(0, host_.pending_requests());
@@ -2017,7 +2017,7 @@ TEST_P(ResourceDispatcherHostTest, TestProcessCancelDetachedTimesOut) {
base::OneShotTimer timer;
timer.Start(FROM_HERE, base::TimeDelta::FromMilliseconds(210),
base::MessageLoop::current(), &base::MessageLoop::QuitWhenIdle);
ncarter (slow) 2016/06/22 20:51:09 Ditto
- base::MessageLoop::current()->Run();
+ base::RunLoop().Run();
// The prefetch should be cancelled by now.
EXPECT_EQ(0, host_.pending_requests());

Powered by Google App Engine
This is Rietveld 408576698