content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc - Issue 2082343002: Remove calls to deprecated MessageLoop methods in content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

Issue 2082343002: Remove calls to deprecated MessageLoop methods in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/devtools_manager_unittest.cc ('K') | « content/browser/fileapi/local_file_stream_reader_unittest.cc ('k') | content/browser/frame_host/render_widget_host_view_guest_unittest.cc » ('j') | content/browser/frame_host/render_widget_host_view_guest_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

index c395fa5377fa691423b8e1398f02075f99aebf75..7b7d428e68f6357bbcd766f13bd9e1a7c39ecf68 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

@@ -11,6 +11,7 @@

#include "base/macros.h"

#include "base/memory/ptr_util.h"

#include "base/message_loop/message_loop.h"

+#include "base/single_thread_task_runner.h"

#include "build/build_config.h"

#include "cc/surfaces/surface.h"

#include "cc/surfaces/surface_factory.h"

@@ -99,7 +100,8 @@ class RenderWidgetHostViewChildFrameTest : public testing::Test {

browser_context_.reset();

- message_loop_.DeleteSoon(FROM_HERE, browser_context_.release());

+ message_loop_.task_runner()->DeleteSoon(FROM_HERE,

+ browser_context_.release());

message_loop_.RunUntilIdle();

ncarter (slow) 2016/06/22 20:51:09 Should this be converted to base::RunLoop().RunUnt

fdoray 2016/06/28 20:40:35 Done.

#if !defined(OS_ANDROID)

ImageTransportFactory::Terminate();