Issue 2082323002: Remove calls to deprecated MessageLoop methods in cc.

Issue 2082323002: Remove calls to deprecated MessageLoop methods in cc. (Closed)

Created:
4 years, 6 months ago by fdoray

Modified:
4 years, 6 months ago

Reviewers:
danakj

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove calls to deprecated MessageLoop methods in cc. This CL makes the following replacements in cc: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 R=danakj@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/70df5a951c7f1acc97104d985f8f25d7d9c96b31 Cr-Commit-Position: refs/heads/master@{#401405}

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -20 lines)			Patch
	M	cc/layers/texture_layer_unittest.cc	View		15 chunks	+19 lines, -19 lines	0 comments	Download
	M	cc/test/layer_tree_test.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

fdoray

Description was changed from ========== Remove calls to deprecated MessageLoop methods in cc. This CL ...

4 years, 6 months ago (2016-06-22 13:52:27 UTC) #1

Description was changed from

==========
Remove calls to deprecated MessageLoop methods in cc.

This CL makes the following replacements in
cc:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=danakj@chromium.org
==========

to

==========
Remove calls to deprecated MessageLoop methods in cc.

This CL makes the following replacements in
cc:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082323002/1

4 years, 6 months ago (2016-06-22 20:43:30 UTC) #5

commit-bot: I haz the power

Description was changed from ========== Remove calls to deprecated MessageLoop methods in cc. This CL ...

4 years, 6 months ago (2016-06-22 21:15:58 UTC) #7

Message was sent while issue was closed.

Description was changed from

==========
Remove calls to deprecated MessageLoop methods in cc.

This CL makes the following replacements in
cc:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remove calls to deprecated MessageLoop methods in cc.

This CL makes the following replacements in
cc:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()
x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |y| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()

 y.message_loop()->task_runner()
                      y.task_runner()
y->message_loop()->task_runner()
                      y->task_runner()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread
or a pointer to a base::Thread.

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447
R=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/70df5a951c7f1acc97104d985f8f25d7d9c96b31
Cr-Commit-Position: refs/heads/master@{#401405}
==========

commit-bot: I haz the power

4 years, 6 months ago (2016-06-22 21:16:00 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/70df5a951c7f1acc97104d985f8f25d7d9c96b31
Cr-Commit-Position: refs/heads/master@{#401405}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages