Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2082283002: [mb] Switch remaining ports to mb (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@mb26
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mb] Switch remaining ports to mb BUG=chromium:616035 NOTRY=true Committed: https://crrev.com/f86cabe67487a969f53039c063b7330885c4a615 Cr-Commit-Position: refs/heads/master@{#37248}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -4 lines) Patch
M infra/mb/mb_config.pyl View 9 chunks +102 lines, -4 lines 4 comments Download

Depends on Patchset:

Issue 2083153003 Patch 1

Dependent Patchsets:

Issue 2081263003 Patch 1

Messages

Total messages: 11 (5 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2082283002/diff/1/infra/mb/mb_config.pyl File infra/mb/mb_config.pyl (right): https://codereview.chromium.org/2082283002/diff/1/infra/mb/mb_config.pyl#newcode69 infra/mb/mb_config.pyl:69: 'client.v8.ports': { Links: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20builder/builds/1616/steps/gclient%20runhooks/logs/stdio https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20builder/builds/1349/steps/gclient%20runhooks/logs/stdio https://build.chromium.org/p/client.v8.ports/builders/V8%20Android%20Arm%20-%20builder/builds/1618/steps/gclient%20runhooks/logs/stdio https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20-%20sim/builds/1304/steps/gclient%20runhooks/logs/stdio https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/builds/1064/steps/gclient%20runhooks/logs/stdio ...
4 years, 6 months ago (2016-06-22 10:33:06 UTC) #3
vogelheim
lgtm https://codereview.chromium.org/2082283002/diff/1/infra/mb/mb_config.pyl File infra/mb/mb_config.pyl (right): https://codereview.chromium.org/2082283002/diff/1/infra/mb/mb_config.pyl#newcode82 infra/mb/mb_config.pyl:82: 'V8 Linux - arm64 - sim - gc ...
4 years, 6 months ago (2016-06-22 13:07:00 UTC) #4
Michael Achenbach
https://codereview.chromium.org/2082283002/diff/1/infra/mb/mb_config.pyl File infra/mb/mb_config.pyl (right): https://codereview.chromium.org/2082283002/diff/1/infra/mb/mb_config.pyl#newcode82 infra/mb/mb_config.pyl:82: 'V8 Linux - arm64 - sim - gc stress': ...
4 years, 6 months ago (2016-06-22 13:55:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082283002/1
4 years, 6 months ago (2016-06-24 10:15:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 10:17:31 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 10:20:12 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f86cabe67487a969f53039c063b7330885c4a615
Cr-Commit-Position: refs/heads/master@{#37248}

Powered by Google App Engine
This is Rietveld 408576698