Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2082273002: Make Miguel and Peter and Robert mac notification OWNERS (Closed)

Created:
4 years, 6 months ago by Miguel Garcia
Modified:
4 years, 6 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Miguel and Peter and Robert mac notification OWNERS BUG= Committed: https://crrev.com/c5e917ef88dec9431dce7ec6bd931d1ab17eeae7 Cr-Commit-Position: refs/heads/master@{#401577}

Patch Set 1 : owners #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/notifications/OWNERS View 1 chunk +6 lines, -0 lines 1 comment Download
M chrome/browser/ui/cocoa/notifications/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Miguel Garcia
4 years, 6 months ago (2016-06-22 09:34:25 UTC) #5
Peter Beverloo
lgtm Please update your CL's subject to match the first line of the message :-). ...
4 years, 6 months ago (2016-06-22 10:46:43 UTC) #6
Robert Sesek
lgtm
4 years, 6 months ago (2016-06-22 22:23:06 UTC) #7
Robert Sesek
Please seek out a Cocoa reviewer, though, for sanity checks.
4 years, 6 months ago (2016-06-22 22:23:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082273002/40001
4 years, 6 months ago (2016-06-23 10:03:39 UTC) #10
Miguel Garcia
On 2016/06/22 22:23:35, Robert Sesek wrote: > Please seek out a Cocoa reviewer, though, for ...
4 years, 6 months ago (2016-06-23 10:03:41 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 6 months ago (2016-06-23 10:46:16 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 10:47:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5e917ef88dec9431dce7ec6bd931d1ab17eeae7
Cr-Commit-Position: refs/heads/master@{#401577}

Powered by Google App Engine
This is Rietveld 408576698