Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 208223006: Revert of Add creation of ServiceManager to Content (Closed)

Created:
6 years, 9 months ago by vandebo (ex-Chrome)
Modified:
6 years, 9 months ago
Reviewers:
jam, DaveMoore, sky
CC:
chromium-reviews, viettrungluu+watch_chromium.org, abarth-chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Revert of Add creation of ServiceManager to Content (https://codereview.chromium.org/187183002/) Reason for revert: Tests fail on Mac Original issue's description: > Add creation of ServiceManager to Content > > BUG=None > TEST=Mojo.Init > R=jam@chromium.org, sky@chromium.org, jam > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258438 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258607 TBR=jam@chromium.org,sky@chromium.org,davemoore@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -214 lines) Patch
M content/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/content_main_runner.cc View 3 chunks +1 line, -10 lines 0 comments Download
D content/app/mojo/mojo_browsertest.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D content/app/mojo/mojo_init.h View 1 chunk +0 lines, -15 lines 0 comments Download
D content/app/mojo/mojo_init.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M content/common/mojo/mojo_channel_init.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M content/content_app.gypi View 2 chunks +0 lines, -15 lines 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +0 lines, -11 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo.gyp View 4 chunks +3 lines, -11 lines 0 comments Download
M mojo/mojo_examples.gypi View 5 chunks +5 lines, -6 lines 0 comments Download
M mojo/mojo_public.gypi View 1 chunk +8 lines, -19 lines 0 comments Download
M mojo/mojo_services.gypi View 1 chunk +1 line, -1 line 0 comments Download
M mojo/service_manager/service_loader.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/service_manager/service_manager.h View 1 chunk +2 lines, -12 lines 0 comments Download
M mojo/service_manager/service_manager.cc View 4 chunks +1 line, -14 lines 0 comments Download
D mojo/service_manager/service_manager_export.h View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vandebo (ex-Chrome)
Created Revert of Add creation of ServiceManager to Content
6 years, 9 months ago (2014-03-21 17:49:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/208223006/1
6 years, 9 months ago (2014-03-21 17:50:05 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 17:51:30 UTC) #3
Message was sent while issue was closed.
Change committed as 258624

Powered by Google App Engine
This is Rietveld 408576698