Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Unified Diff: Source/devtools/front_end/DOMAgent.js

Issue 208223002: DevTools: [Elements] Restore selected shadow DOM elements on reload (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/DOMAgent.js
diff --git a/Source/devtools/front_end/DOMAgent.js b/Source/devtools/front_end/DOMAgent.js
index b0c400dca0579c816f17ca8a9216138f18c33b47..3f2e5ff5c4414fbd92069a3b1fbc80cea216a1db 100644
--- a/Source/devtools/front_end/DOMAgent.js
+++ b/Source/devtools/front_end/DOMAgent.js
@@ -272,6 +272,9 @@ WebInspector.DOMNode.prototype = {
*/
nodeNameInCorrectCase: function()
{
+ var shadowRootType = this.shadowRootType();
+ if (shadowRootType)
+ return "#shadow-root" + (shadowRootType === WebInspector.DOMNode.ShadowRootTypes.UserAgent ? " (user-agent)" : "");
return this.isXMLNode() ? this.nodeName() : this.nodeName().toLowerCase();
},
@@ -466,10 +469,19 @@ WebInspector.DOMNode.prototype = {
*/
path: function()
{
+ /**
+ * @param {?WebInspector.DOMNode} node
+ */
+ function canPush(node)
+ {
+ return node && ("index" in node || (node.isShadowRoot() && node.parentNode)) && node._nodeName.length;
+ }
+
var path = [];
var node = this;
- while (node && "index" in node && node._nodeName.length) {
- path.push([node.index, node._nodeName]);
+ while (canPush(node)) {
+ var index = typeof node.index === "number" ? node.index : (node.shadowRootType() === WebInspector.DOMNode.ShadowRootTypes.UserAgent ? "u" : "a");
pfeldman 2014/03/21 15:02:52 Where is this used though?
apavlov 2014/03/21 15:26:46 This is used in WebInspector.DOMNode.prototype.pat
+ path.push([index, node._nodeName]);
node = node.parentNode;
}
path.reverse();

Powered by Google App Engine
This is Rietveld 408576698