Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 208223002: DevTools: [Elements] Restore selected shadow DOM elements on reload (Closed)

Created:
6 years, 9 months ago by apavlov
Modified:
6 years, 9 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: [Elements] Restore selected shadow DOM elements on reload R=pfeldman, vsevik BUG=354853 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169842

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -17 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 1 chunk +6 lines, -1 line 0 comments Download
A LayoutTests/inspector/elements/elements-panel-shadow-selection-on-refresh.html View 1 1 chunk +96 lines, -0 lines 0 comments Download
A LayoutTests/inspector/elements/elements-panel-shadow-selection-on-refresh-expected.txt View 1 1 chunk +21 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 2 chunks +24 lines, -7 lines 0 comments Download
M Source/devtools/front_end/DOMAgent.js View 2 chunks +14 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ElementsTreeOutline.js View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
apavlov
6 years, 9 months ago (2014-03-21 13:48:06 UTC) #1
pfeldman
https://codereview.chromium.org/208223002/diff/1/LayoutTests/inspector/elements/elements-panel-selection-on-refresh-expected.txt File LayoutTests/inspector/elements/elements-panel-selection-on-refresh-expected.txt (right): https://codereview.chromium.org/208223002/diff/1/LayoutTests/inspector/elements/elements-panel-selection-on-refresh-expected.txt#newcode4 LayoutTests/inspector/elements/elements-panel-selection-on-refresh-expected.txt:4: Running: setup You want a new test for this. ...
6 years, 9 months ago (2014-03-21 15:02:52 UTC) #2
apavlov
https://codereview.chromium.org/208223002/diff/1/LayoutTests/inspector/elements/elements-panel-selection-on-refresh-expected.txt File LayoutTests/inspector/elements/elements-panel-selection-on-refresh-expected.txt (right): https://codereview.chromium.org/208223002/diff/1/LayoutTests/inspector/elements/elements-panel-selection-on-refresh-expected.txt#newcode4 LayoutTests/inspector/elements/elements-panel-selection-on-refresh-expected.txt:4: Running: setup On 2014/03/21 15:02:52, pfeldman wrote: > You ...
6 years, 9 months ago (2014-03-21 15:26:46 UTC) #3
pfeldman
lgtm
6 years, 9 months ago (2014-03-24 10:18:31 UTC) #4
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 9 months ago (2014-03-24 10:37:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/208223002/20001
6 years, 9 months ago (2014-03-24 10:37:41 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 10:40:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 10:40:33 UTC) #8
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 9 months ago (2014-03-24 11:25:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/208223002/20001
6 years, 9 months ago (2014-03-24 11:25:39 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 11:59:39 UTC) #11
Message was sent while issue was closed. 
Change committed as 169842

Powered by Google App Engine
This is Rietveld 408576698