Add CTVerifier and CTPolicyEnforcer to cast channel ssl socket

Add CTVerifier and CTPolicyEnforcer to cast channel ssl socket

This change adds the CTVerifier and CTPolicyEnforcer parameters to the
ssl context when initializing an ssl socket for a cast channel. These
were became required by https://codereview.chromium.org/2067843003 but
this code wasn't updated because it is not used in tests.

BUG=622098
Committed: https://crrev.com/f0df1d51b68f008d04d38f53b8f7758407375a65
Cr-Commit-Position: refs/heads/master@{#401514}

[btolsch, 2016-06-22 01:22:39]

btolsch@chromium.org changed reviewers:
+ imcheng@chromium.org, wez@chromium.org

[btolsch, 2016-06-22 01:22:40]

PTAL. This code isn't currently used in tests (which caused this regression in
the first place) so I'll see about adding some, but I'm open to suggestions here
since I'm not very familiar with this code.

[imcheng, 2016-06-22 03:06:03]

LGTM

I am fine with landing the unit tests separately once you have manually verified
that this fixes the crash. The existing tests looks complicated to me and will
require some time to refactor. I wonder if we could inject a fake socket into
CreateSslSocket() for testing, instead of mocking out the entire method.

https://codereview.chromium.org/2082213002/diff/1/extensions/browser/api/cast...
File extensions/browser/api/cast_channel/cast_socket.cc (right):

https://codereview.chromium.org/2082213002/diff/1/extensions/browser/api/cast...
extensions/browser/api/cast_channel/cast_socket.cc:194: // CertVerifier and
TransportSecurityState are owned by us, not the
nit: Update this comment.

[Ryan Sleevi, 2016-06-23 00:48:06]

rsleevi@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2016-06-23 00:48:06]

LGTM as well.

[Wez, 2016-06-23 00:56:48]

lgtm

https://codereview.chromium.org/2082213002/diff/1/extensions/browser/api/cast...
File extensions/browser/api/cast_channel/cast_socket.cc (right):

https://codereview.chromium.org/2082213002/diff/1/extensions/browser/api/cast...
extensions/browser/api/cast_channel/cast_socket.cc:194: // CertVerifier and
TransportSecurityState are owned by us, not the
On 2016/06/22 03:06:03, imcheng wrote:
> nit: Update this comment.

And add a blank line between the comment and the preceding line, since it's a
block comment.  Also suggest moving |context| below the comment and rephrasing
just to "Note that the |context| fields remain owned by CastSocketImpl."

[btolsch, 2016-06-23 01:04:18]

The CQ bit was checked by btolsch@chromium.org

[btolsch, 2016-06-23 01:04:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
imcheng@chromium.org, rsleevi@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/2082213002/#ps40001
(title: "Re-re-comment")

[commit-bot: I haz the power, 2016-06-23 01:05:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2082213002/40001

[commit-bot: I haz the power, 2016-06-23 01:51:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-23 01:57:15]

Description was changed from

==========
Add CTVerifier and CTPolicyEnforcer to cast channel ssl socket

This change adds the CTVerifier and CTPolicyEnforcer parameters to the
ssl context when initializing an ssl socket for a cast channel. These
were became required by https://codereview.chromium.org/2067843003 but
this code wasn't updated because it is not used in tests.

BUG=622098
==========

to

==========
Add CTVerifier and CTPolicyEnforcer to cast channel ssl socket

This change adds the CTVerifier and CTPolicyEnforcer parameters to the
ssl context when initializing an ssl socket for a cast channel. These
were became required by https://codereview.chromium.org/2067843003 but
this code wasn't updated because it is not used in tests.

BUG=622098

Committed: https://crrev.com/f0df1d51b68f008d04d38f53b8f7758407375a65
Cr-Commit-Position: refs/heads/master@{#401514}
==========

[commit-bot: I haz the power, 2016-06-23 01:57:16]

Patchset 3 (id:??) landed as
https://crrev.com/f0df1d51b68f008d04d38f53b8f7758407375a65
Cr-Commit-Position: refs/heads/master@{#401514}