Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2082193002: mash: Migrate locale observer and notification to common. (Closed)

Created:
4 years, 6 months ago by msw
Modified:
4 years, 6 months ago
Reviewers:
James Cook, stevenjb
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Migrate locale observer and notification to common. tools/git/move_source_file.py ash/system/locale/* ash/common/system/locale Move LocaleObserver and Notify functions to WmSystemTrayNotifier. Add locale_observer.h to the build config. Fix some IWYU issues. BUG=619636 TEST=compiles, no regressions (had to hack for manual testing...) R=jamescook@chromium.org,stevenjb@chromium.org Committed: https://crrev.com/6784963ea28707482c8e5bd12966ddad2857fe41 Cr-Commit-Position: refs/heads/master@{#401191}

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Format #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -241 lines) Patch
M ash/ash.gyp View 1 2 chunks +3 lines, -2 lines 0 comments Download
A + ash/common/system/locale/locale_notification_controller.h View 2 chunks +4 lines, -5 lines 0 comments Download
A + ash/common/system/locale/locale_notification_controller.cc View 1 2 3 chunks +7 lines, -8 lines 0 comments Download
A + ash/common/system/locale/locale_observer.h View 2 chunks +5 lines, -3 lines 0 comments Download
M ash/common/system/tray/wm_system_tray_notifier.h View 3 chunks +11 lines, -1 line 1 comment Download
M ash/common/system/tray/wm_system_tray_notifier.cc View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M ash/shell.cc View 2 chunks +1 line, -1 line 0 comments Download
D ash/system/locale/locale_notification_controller.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ash/system/locale/locale_notification_controller.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D ash/system/locale/locale_observer.h View 1 chunk +0 lines, -32 lines 0 comments Download
M ash/system/tray/system_tray_notifier.h View 4 chunks +0 lines, -9 lines 0 comments Download
M ash/system/tray/system_tray_notifier.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/locale_change_guard.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/locale_change_guard.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
msw
Please take a look thanks! James: ash/* Steven: c/b/chromeos/*
4 years, 6 months ago (2016-06-22 00:02:53 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082193002/40001
4 years, 6 months ago (2016-06-22 00:03:55 UTC) #4
stevenjb
lgtm
4 years, 6 months ago (2016-06-22 00:22:46 UTC) #5
James Cook
LGTM https://codereview.chromium.org/2082193002/diff/40001/ash/common/system/tray/wm_system_tray_notifier.h File ash/common/system/tray/wm_system_tray_notifier.h (right): https://codereview.chromium.org/2082193002/diff/40001/ash/common/system/tray/wm_system_tray_notifier.h#newcode78 ash/common/system/tray/wm_system_tray_notifier.h:78: base::ObserverList<ClockObserver> clock_observers_; thanks for fixing this ordering
4 years, 6 months ago (2016-06-22 02:53:29 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 03:07:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082193002/40001
4 years, 6 months ago (2016-06-22 03:11:59 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-22 03:19:11 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 03:22:35 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6784963ea28707482c8e5bd12966ddad2857fe41
Cr-Commit-Position: refs/heads/master@{#401191}

Powered by Google App Engine
This is Rietveld 408576698