Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2082183002: Add 'chrome_official_builder' target to //BUILD.gn. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add 'chrome_official_builder' target to //BUILD.gn. This is needed on the official 32-bit win desktop builder. R=brettw@chromium.org BUG=605318 Committed: https://crrev.com/33e626ee1d4e57f64aea682f8479e65ecf59e7ac Cr-Commit-Position: refs/heads/master@{#401540}

Patch Set 1 #

Patch Set 2 : fix typos #

Patch Set 3 : fix other paths #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M BUILD.gn View 1 2 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Dirk Pranke
4 years, 6 months ago (2016-06-21 23:24:26 UTC) #1
brettw
lgtm
4 years, 6 months ago (2016-06-21 23:25:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082183002/1
4 years, 6 months ago (2016-06-21 23:32:02 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/233219)
4 years, 6 months ago (2016-06-21 23:40:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082183002/20001
4 years, 6 months ago (2016-06-22 04:13:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/243098) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 6 months ago (2016-06-22 04:18:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082183002/40001
4 years, 6 months ago (2016-06-23 03:43:05 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-23 04:41:48 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 04:44:00 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/33e626ee1d4e57f64aea682f8479e65ecf59e7ac
Cr-Commit-Position: refs/heads/master@{#401540}

Powered by Google App Engine
This is Rietveld 408576698