Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2082173002: New go generator shakedown. (Closed)

Created:
4 years, 6 months ago by azani
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

New go generator shakedown. Fix a number of bugs. Add serialization for interfaces and interface requests. Add the sha1 files for the go generator so it is downloaded by gclient sync. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/58dc9a37daaf13b8da523562c86d0c21a2fc00d3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -56 lines) Patch
A mojo/public/tools/bindings/mojom_tool/bin/linux64/generators/go.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/tools/bindings/mojom_tool/bin/mac64/generators/go.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M mojom/generators/go/templates/decoding.go View 3 chunks +29 lines, -0 lines 2 comments Download
M mojom/generators/go/templates/decoding_test.go View 1 chunk +69 lines, -0 lines 0 comments Download
M mojom/generators/go/templates/encoding.go View 2 chunks +7 lines, -1 line 0 comments Download
M mojom/generators/go/templates/encoding_test.go View 3 chunks +72 lines, -0 lines 0 comments Download
M mojom/generators/go/templates/interfaces.go View 6 chunks +9 lines, -11 lines 0 comments Download
M mojom/generators/go/templates/structs.go View 1 chunk +1 line, -0 lines 0 comments Download
M mojom/generators/go/templates/templates.go View 2 chunks +4 lines, -1 line 0 comments Download
M mojom/generators/go/translator/encoding_info.go View 1 chunk +7 lines, -19 lines 0 comments Download
M mojom/generators/go/translator/mojom_file.go View 8 chunks +65 lines, -20 lines 0 comments Download
M mojom/generators/go/translator/translator.go View 2 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
azani
4 years, 6 months ago (2016-06-21 23:03:08 UTC) #3
vardhan
lgtm https://codereview.chromium.org/2082173002/diff/1/mojom/generators/go/templates/decoding.go File mojom/generators/go/templates/decoding.go (right): https://codereview.chromium.org/2082173002/diff/1/mojom/generators/go/templates/decoding.go#newcode12 mojom/generators/go/templates/decoding.go:12: {{- define "AmpersandIfNullable" -}} haha https://codereview.chromium.org/2082173002/diff/1/mojom/generators/go/templates/decoding.go#newcode47 mojom/generators/go/templates/decoding.go:47: {{- ...
4 years, 6 months ago (2016-06-22 15:17:15 UTC) #4
azani
4 years, 6 months ago (2016-06-22 18:22:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58dc9a37daaf13b8da523562c86d0c21a2fc00d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698