Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2082103002: Add documentation about no sources for GN guide. (Closed)

Created:
4 years, 6 months ago by brettw
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add documentation about no sources for GN guide. This just adds another consideration for source sets versus static libraries. TBR=dpranke Committed: https://crrev.com/120e860e372e1654422696dcb8ab49a22e438d78 Cr-Commit-Position: refs/heads/master@{#401103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/gn/docs/style_guide.md View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brettw
4 years, 6 months ago (2016-06-21 19:48:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082103002/1
4 years, 6 months ago (2016-06-21 19:49:34 UTC) #3
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-21 19:52:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 20:50:19 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 20:52:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/120e860e372e1654422696dcb8ab49a22e438d78
Cr-Commit-Position: refs/heads/master@{#401103}

Powered by Google App Engine
This is Rietveld 408576698