Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: Source/core/rendering/RenderLayerScrollableArea.cpp

Issue 208203002: Don't rely on values computed as a side effect of paint. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: . Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderLayer.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 if (repaintContainer) 388 if (repaintContainer)
389 quadForFakeMouseMoveEvent = repaintContainer->localToAbsoluteQuad(quadFo rFakeMouseMoveEvent); 389 quadForFakeMouseMoveEvent = repaintContainer->localToAbsoluteQuad(quadFo rFakeMouseMoveEvent);
390 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseM oveEvent); 390 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseM oveEvent);
391 391
392 bool requiresRepaint = true; 392 bool requiresRepaint = true;
393 393
394 if (m_box->view()->compositor()->inCompositingMode()) { 394 if (m_box->view()->compositor()->inCompositingMode()) {
395 bool onlyScrolledCompositedLayers = scrollsOverflow() 395 bool onlyScrolledCompositedLayers = scrollsOverflow()
396 && !layer()->hasVisibleNonLayerContent() 396 && !layer()->hasVisibleNonLayerContent()
397 && !layer()->hasNonCompositedChild() 397 && !layer()->hasNonCompositedChild()
398 && !layer()->hasBlockSelectionGapBounds() 398 && !m_box->isMarquee()
399 && !m_box->isMarquee(); 399 && layer()->renderer()->selectionRect().isEmpty();
400 400
401 if (usesCompositedScrolling() || onlyScrolledCompositedLayers) 401 if (usesCompositedScrolling() || onlyScrolledCompositedLayers)
402 requiresRepaint = false; 402 requiresRepaint = false;
403 } 403 }
404 404
405 // Just schedule a full repaint of our object. 405 // Just schedule a full repaint of our object.
406 if (requiresRepaint) { 406 if (requiresRepaint) {
407 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled()) { 407 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled()) {
408 if (m_box->frameView()->isInPerformLayout()) 408 if (m_box->frameView()->isInPerformLayout())
409 m_box->setShouldDoFullRepaintAfterLayout(true); 409 m_box->setShouldDoFullRepaintAfterLayout(true);
(...skipping 1135 matching lines...) Expand 10 before | Expand all | Expand 10 after
1545 void RenderLayerScrollableArea::setForceNeedsCompositedScrolling(ForceNeedsCompo sitedScrollingMode mode) 1545 void RenderLayerScrollableArea::setForceNeedsCompositedScrolling(ForceNeedsCompo sitedScrollingMode mode)
1546 { 1546 {
1547 if (m_forceNeedsCompositedScrolling == mode) 1547 if (m_forceNeedsCompositedScrolling == mode)
1548 return; 1548 return;
1549 1549
1550 m_forceNeedsCompositedScrolling = mode; 1550 m_forceNeedsCompositedScrolling = mode;
1551 layer()->didUpdateNeedsCompositedScrolling(); 1551 layer()->didUpdateNeedsCompositedScrolling();
1552 } 1552 }
1553 1553
1554 } // Namespace WebCore 1554 } // Namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698