Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Side by Side Diff: Source/core/rendering/RenderLayer.cpp

Issue 208203002: Don't rely on values computed as a side effect of paint. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: . Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 3295 matching lines...) Expand 10 before | Expand all | Expand 10 after
3306 rect.move(-box->scrolledContentOffset()); 3306 rect.move(-box->scrolledContentOffset());
3307 if (!scrollableArea()->usesCompositedScrolling()) 3307 if (!scrollableArea()->usesCompositedScrolling())
3308 rect.intersect(box->overflowClipRect(LayoutPoint())); 3308 rect.intersect(box->overflowClipRect(LayoutPoint()));
3309 } 3309 }
3310 if (renderer()->hasClip()) 3310 if (renderer()->hasClip())
3311 rect.intersect(toRenderBox(renderer())->clipRect(LayoutPoint())); 3311 rect.intersect(toRenderBox(renderer())->clipRect(LayoutPoint()));
3312 if (!rect.isEmpty()) 3312 if (!rect.isEmpty())
3313 renderer()->repaintRectangle(rect); 3313 renderer()->repaintRectangle(rect);
3314 } 3314 }
3315 3315
3316 bool RenderLayer::hasBlockSelectionGapBounds() const
3317 {
3318 return !m_blockSelectionGapsBounds.isEmpty();
3319 }
3320
3321 bool RenderLayer::intersectsDamageRect(const LayoutRect& layerBounds, const Layo utRect& damageRect, const RenderLayer* rootLayer, const LayoutPoint* offsetFromR oot) const 3316 bool RenderLayer::intersectsDamageRect(const LayoutRect& layerBounds, const Layo utRect& damageRect, const RenderLayer* rootLayer, const LayoutPoint* offsetFromR oot) const
3322 { 3317 {
3323 // Always examine the canvas and the root. 3318 // Always examine the canvas and the root.
3324 // FIXME: Could eliminate the isRoot() check if we fix background painting s o that the RenderView 3319 // FIXME: Could eliminate the isRoot() check if we fix background painting s o that the RenderView
3325 // paints the root's background. 3320 // paints the root's background.
3326 if (isRootLayer() || renderer()->isRoot()) 3321 if (isRootLayer() || renderer()->isRoot())
3327 return true; 3322 return true;
3328 3323
3329 // If we aren't an inline flow, and our layer bounds do intersect the damage rect, then we 3324 // If we aren't an inline flow, and our layer bounds do intersect the damage rect, then we
3330 // can go ahead and return true. 3325 // can go ahead and return true.
(...skipping 825 matching lines...) Expand 10 before | Expand all | Expand 10 after
4156 } 4151 }
4157 } 4152 }
4158 4153
4159 void showLayerTree(const WebCore::RenderObject* renderer) 4154 void showLayerTree(const WebCore::RenderObject* renderer)
4160 { 4155 {
4161 if (!renderer) 4156 if (!renderer)
4162 return; 4157 return;
4163 showLayerTree(renderer->enclosingLayer()); 4158 showLayerTree(renderer->enclosingLayer());
4164 } 4159 }
4165 #endif 4160 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayer.h ('k') | Source/core/rendering/RenderLayerScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698