Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 2082023002: [test] add FunctionMirror and PromiseMirror tests for async functions (Closed)

Created:
4 years, 6 months ago by caitp (gmail)
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg, Yang
CC:
Henrique Ferreiro, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] add FunctionMirror and PromiseMirror tests for async functions BUG=v8:4483 R=yangguo@chromium.org, littledan@chromium.org Committed: https://crrev.com/36dd4780f0f7cf1ae8883fa5118c6c98084c49c8 Cr-Commit-Position: refs/heads/master@{#37149}

Patch Set 1 #

Patch Set 2 : add Promise tests and fix copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -44 lines) Patch
A + test/mjsunit/harmony/mirror-async-function.js View 1 3 chunks +17 lines, -32 lines 0 comments Download
A + test/mjsunit/harmony/mirror-async-function-promise.js View 1 3 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
caitp (gmail)
PTAL As noted on the bug, there isn't really a place for GeneratorMirror WRT async ...
4 years, 6 months ago (2016-06-21 14:47:15 UTC) #1
Dan Ehrenberg
lgtm
4 years, 6 months ago (2016-06-21 16:04:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082023002/20001
4 years, 6 months ago (2016-06-21 16:07:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 16:28:01 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 16:32:02 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36dd4780f0f7cf1ae8883fa5118c6c98084c49c8
Cr-Commit-Position: refs/heads/master@{#37149}

Powered by Google App Engine
This is Rietveld 408576698