Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/chrome_tests.gypi

Issue 2082002: Make the workaround from bug 43791 unconditional (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables' : { 6 'variables' : {
7 'browser_tests_sources_views_specific': [ 7 'browser_tests_sources_views_specific': [
8 'browser/extensions/browser_action_test_util_views.cc', 8 'browser/extensions/browser_action_test_util_views.cc',
9 'browser/views/browser_actions_container_browsertest.cc', 9 'browser/views/browser_actions_container_browsertest.cc',
10 ], 10 ],
(...skipping 1118 matching lines...) Expand 10 before | Expand all | Expand 10 after
1129 'browser/gtk/go_button_gtk_unittest.cc', 1129 'browser/gtk/go_button_gtk_unittest.cc',
1130 'browser/gtk/tabs/tab_renderer_gtk_unittest.cc', 1130 'browser/gtk/tabs/tab_renderer_gtk_unittest.cc',
1131 'tools/convert_dict/convert_dict_unittest.cc', 1131 'tools/convert_dict/convert_dict_unittest.cc',
1132 '../third_party/hunspell/google/hunspell_tests.cc', 1132 '../third_party/hunspell/google/hunspell_tests.cc',
1133 ], 1133 ],
1134 # TODO(mark): We really want this for all non-static library targets, 1134 # TODO(mark): We really want this for all non-static library targets,
1135 # but when we tried to pull it up to the common.gypi level, it broke 1135 # but when we tried to pull it up to the common.gypi level, it broke
1136 # other things like the ui, startup, and page_cycler tests. *shrug* 1136 # other things like the ui, startup, and page_cycler tests. *shrug*
1137 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-ObjC']}, 1137 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-ObjC']},
1138 1138
1139 # The Mac Valgrind and Coverage builds use compilation 1139 # libwebcore.a is so large that ld may not have a sufficiently large
1140 # settings that cause their code size to swell more than any 1140 # "hole" in its address space into which it can be mmaped by the
1141 # other build. In particular, libwebcore.a is so large that 1141 # time it reaches this library. As of May 10, 2010, libwebcore.a is
1142 # ld may not have a sufficiently large "hole" in its address 1142 # about 1GB in some builds. In the Mac OS X 10.5 toolchain, using
1143 # space into which it can be mmaped by the time it reaches 1143 # Xcode 3.1, ld is only a 32-bit executable, and address space
1144 # this library. As of May 10, 2010, libwebcore.a is 1023MB
1145 # in this build. In the Mac OS X 10.5 toolchain, using Xcode
1146 # 3.1, ld is only a 32-bit executable, and address space
1147 # exhaustion is the result, with ld failing and producing 1144 # exhaustion is the result, with ld failing and producing
1148 # the message: 1145 # the message:
1149 # ld: in .../libwebcore.a, can't map file, errno=12 1146 # ld: in .../libwebcore.a, can't map file, errno=12
1150 # 1147 #
1151 # As a workaround, in these builds, ensure that libwebcore.a 1148 # As a workaround, ensure that libwebcore.a appears to ld first when
1152 # appears to ld first when linking unit_tests. This allows 1149 # linking unit_tests. This allows the library to be mmapped when
1153 # the library to be mmaped when ld's address space is "wide 1150 # ld's address space is "wide open." Other libraries are small
1154 # open." Other libraries are small enough that they'll be 1151 # enough that they'll be able to "squeeze" into the remaining holes.
1155 # able to "squeeze" into the remaining holes. The Mac linker 1152 # The Mac linker isn't so sensitive that moving this library to the
1156 # isn't so sensitive that moving this library to the front 1153 # front of the list will cause problems.
1157 # of the list will cause problems. 1154 #
1158 'variables': { 1155 # Enough pluses to make get this target prepended to the target's
1159 # release_valgrind_build may not be defined at this point, so 1156 # list of dependencies.
1160 # provide a default definition here (matching the one in 1157 'dependencies+++': [
1161 # build/common.gypi). 1158 '../third_party/WebKit/WebCore/WebCore.gyp/WebCore.gyp:webcore',
1162 'release_valgrind_build%': 0,
1163 },
1164 'conditions': [
1165 ['release_valgrind_build==1 or coverage==1', {
1166 # Enough pluses to make get this target prepended to the
1167 # target's list of dependencies.
1168 'dependencies+++': [
1169 '../third_party/WebKit/WebCore/WebCore.gyp/WebCore.gyp:webcore',
1170 ],
1171 }],
1172 ], 1159 ],
1173 }, { # OS != "mac" 1160 }, { # OS != "mac"
1174 'dependencies': [ 1161 'dependencies': [
1175 'convert_dict_lib', 1162 'convert_dict_lib',
1176 '../third_party/hunspell/hunspell.gyp:hunspell', 1163 '../third_party/hunspell/hunspell.gyp:hunspell',
1177 ], 1164 ],
1178 }], 1165 }],
1179 ['OS=="win"', { 1166 ['OS=="win"', {
1180 'defines': [ 1167 'defines': [
1181 '__STD_C', 1168 '__STD_C',
(...skipping 1217 matching lines...) Expand 10 before | Expand all | Expand 10 after
2399 ] 2386 ]
2400 }], # 'coverage!=0' 2387 }], # 'coverage!=0'
2401 ], # 'conditions' 2388 ], # 'conditions'
2402 } 2389 }
2403 2390
2404 # Local Variables: 2391 # Local Variables:
2405 # tab-width:2 2392 # tab-width:2
2406 # indent-tabs-mode:nil 2393 # indent-tabs-mode:nil
2407 # End: 2394 # End:
2408 # vim: set expandtab tabstop=2 shiftwidth=2: 2395 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698