Issue 2082002: Make the workaround from bug 43791 unconditional

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2082002: Make the workaround from bug 43791 unconditional (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years ago by Mark Mentovai - out til August

Modified:
4 years ago

Reviewers:
yurys

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make the workaround from bug 43791 unconditional. When linking unit_tests on the Mac, always give libwebcore.a to the linker first. BUG=43791 TEST=unit_tests should link on Mac in debug mode Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47147

Patch Set 1 #

Patch Set 2 : '' #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -29 lines)			Patch
	M	chrome/chrome_tests.gypi	View	1	1 chunk	+16 lines, -29 lines	0 comments	Download

Trybot results:

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai - out til August

5 years ago (2010-05-13 16:07:20 UTC) #1

TBR (build break) following WebKit roll at r47143

Expand Messages | Collapse Messages