Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2081973003: Refactor module builder (Closed)

Created:
4 years, 6 months ago by rossberg
Modified:
4 years, 6 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactor module builder - Use ES6 classes and other goodies. - Make some names match design/spec. - Remove obsolete generation of END section. R=bradnelson@chromium.org BUG= Committed: https://crrev.com/271a7f55cd4a40e09d6bd1e9fd4f518e3f8dd719 Cr-Commit-Position: refs/heads/master@{#37155}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -307 lines) Patch
M test/mjsunit/wasm/adapter-frame.js View 1 chunk +3 lines, -6 lines 0 comments Download
M test/mjsunit/wasm/ffi.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/gc-frame.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/import-table.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/indirect-calls.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/params.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/stackwalk.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/start-function.js View 2 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/test-wasm-module-builder.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/trap-location.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 2 chunks +32 lines, -24 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 1 chunk +269 lines, -264 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
rossberg
4 years, 6 months ago (2016-06-21 13:24:57 UTC) #1
bradnelson
lgtm https://codereview.chromium.org/2081973003/diff/1/test/mjsunit/wasm/wasm-module-builder.js File test/mjsunit/wasm/wasm-module-builder.js (right): https://codereview.chromium.org/2081973003/diff/1/test/mjsunit/wasm/wasm-module-builder.js#newcode5 test/mjsunit/wasm/wasm-module-builder.js:5: class Binary extends Array { Nice pithy name ...
4 years, 6 months ago (2016-06-21 19:05:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081973003/1
4 years, 6 months ago (2016-06-21 19:05:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 19:47:59 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 19:48:28 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/271a7f55cd4a40e09d6bd1e9fd4f518e3f8dd719
Cr-Commit-Position: refs/heads/master@{#37155}

Powered by Google App Engine
This is Rietveld 408576698