Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2081933002: Fix typo in header guard for crx_file_info.h (Closed)

Created:
4 years, 6 months ago by vivekg_samsung
Modified:
4 years, 6 months ago
Reviewers:
vivekg, Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in header guard for crx_file_info.h R=rdevlin.cronin@chromium.org Committed: https://crrev.com/695ba99b0bc6ccb430963d5397d9db5c36eac1af Cr-Commit-Position: refs/heads/master@{#401014}

Patch Set 1 #

Patch Set 2 : Remove additional '_' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M extensions/browser/crx_file_info.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
vivekg
PTAL, thank you!
4 years, 6 months ago (2016-06-21 10:09:12 UTC) #2
Devlin
This looks good, but please remove the NOTRY=true from your cl description before I sign ...
4 years, 6 months ago (2016-06-21 15:18:33 UTC) #3
vivekg
On 2016/06/21 15:18:33, Devlin wrote: > This looks good, but please remove the NOTRY=true from ...
4 years, 6 months ago (2016-06-21 15:21:20 UTC) #5
Devlin
lgtm, thanks!
4 years, 6 months ago (2016-06-21 15:57:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081933002/20001
4 years, 6 months ago (2016-06-21 15:57:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 16:42:13 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 16:52:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/695ba99b0bc6ccb430963d5397d9db5c36eac1af
Cr-Commit-Position: refs/heads/master@{#401014}

Powered by Google App Engine
This is Rietveld 408576698