Mark stylesheet as having media queries at consume time.

Mark stylesheet as having media queries at consume time.

Marking the stylesheet as having media queries for @media at insertion
time meant we didn't mark the stylesheet when @media was a child rule
of another @-rule like @supports. Instead do the marking from the
consume method like we already did for @font-face rules.

Removed unnecessary marking from insertion methods and an unnecessary
boolean parameter which was always true.

R=timloh@chromium.org
BUG=621502
Committed: https://crrev.com/feb31417375d9bd2cc2f383516c0485dc615286d
Cr-Commit-Position: refs/heads/master@{#402766}

[rune, 2016-06-21 09:58:40]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 09:59:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081893003/1

[commit-bot: I haz the power, 2016-06-21 10:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 10:42:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rune, 2016-06-21 22:33:20]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 22:34:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081893003/40001

[rune, 2016-06-21 22:55:53]

In the last patch set I've tried to not mark the stylesheet as containing media
rules when we parse an @media rule which is not inserted because it's not
allowed in that position of the stylesheet. We still get false positives if the
media rule is parsed as part of an @supports rule like:

  insertRule("@supports (color:pink) { @media (min-width: 100px) { color: green
} }", 0);

and there is an @import in the sheet from before.

The question is if we should just accept false positives and
setHasMediaQueries() from the consume methods. That would make the code simpler.
WDYT?

[commit-bot: I haz the power, 2016-06-22 00:06:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 00:06:33]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Timothy Loh, 2016-06-27 05:50:33]

On 2016/06/21 22:55:53, rune wrote:
> In the last patch set I've tried to not mark the stylesheet as containing
media
> rules when we parse an @media rule which is not inserted because it's not
> allowed in that position of the stylesheet. We still get false positives if
the
> media rule is parsed as part of an @supports rule like:
> 
>   insertRule("@supports (color:pink) { @media (min-width: 100px) { color:
green
> } }", 0);
> 
> and there is an @import in the sheet from before.
> 
> The question is if we should just accept false positives and
> setHasMediaQueries() from the consume methods. That would make the code
simpler.
> WDYT?

I don't think we need to bother handling these cases. Something like PS2 seems
good enough (what's the isMutable check for?)

[rune, 2016-06-27 07:26:21]

On 2016/06/27 05:50:33, Timothy Loh wrote:

> I don't think we need to bother handling these cases. Something like PS2 seems
> good enough (what's the isMutable check for?)

It was an attempt to detect if we parsed for CSSOM rule insertion and let the
rule insertion code set set flag, but the stylesheet is made mutable _after_ the
parsing step, _before_ insertion, so it did not have the effect.

[rune, 2016-06-27 09:12:59]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 09:13:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2016-06-27 09:14:10]

Description was changed from

==========
Mark stylesheet as having media queries at consume time.

Marking the stylesheet as having media queries for @media at insertion
time meant we didn't mark the stylesheet when @media was a child rule
of another @-rule like @supports. Instead do the marking from the
consume method like we already did for @font-face rules.

R=timloh@chromium.org
BUG=621502
==========

to

==========
Mark stylesheet as having media queries at consume time.

Marking the stylesheet as having media queries for @media at insertion
time meant we didn't mark the stylesheet when @media was a child rule
of another @-rule like @supports. Instead do the marking from the
consume method like we already did for @font-face rules.

Removed unnecessary marking from insertion methods and an unnecessary
boolean parameter which was always true.

R=timloh@chromium.org
BUG=621502
==========

[rune, 2016-06-27 09:16:25]

On 2016/06/27 05:50:33, Timothy Loh wrote:

> I don't think we need to bother handling these cases. Something like PS2 seems
> good enough (what's the isMutable check for?)

PS4 is now purely doing it at consume time.

[commit-bot: I haz the power, 2016-06-27 10:36:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 10:37:00]

Dry run: This issue passed the CQ dry run.

[rune, 2016-06-28 10:32:51]

ping

[Timothy Loh, 2016-06-29 02:02:23]

On 2016/06/28 10:32:51, rune wrote:
> ping

lgtm

[rune, 2016-06-29 06:20:12]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-06-29 06:20:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 07:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 07:18:34]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rune, 2016-06-29 09:01:32]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-06-29 09:01:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 10:09:45]

Description was changed from

==========
Mark stylesheet as having media queries at consume time.

Marking the stylesheet as having media queries for @media at insertion
time meant we didn't mark the stylesheet when @media was a child rule
of another @-rule like @supports. Instead do the marking from the
consume method like we already did for @font-face rules.

Removed unnecessary marking from insertion methods and an unnecessary
boolean parameter which was always true.

R=timloh@chromium.org
BUG=621502
==========

to

==========
Mark stylesheet as having media queries at consume time.

Marking the stylesheet as having media queries for @media at insertion
time meant we didn't mark the stylesheet when @media was a child rule
of another @-rule like @supports. Instead do the marking from the
consume method like we already did for @font-face rules.

Removed unnecessary marking from insertion methods and an unnecessary
boolean parameter which was always true.

R=timloh@chromium.org
BUG=621502
==========

[commit-bot: I haz the power, 2016-06-29 10:09:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-29 10:11:47]

Description was changed from

==========
Mark stylesheet as having media queries at consume time.

Marking the stylesheet as having media queries for @media at insertion
time meant we didn't mark the stylesheet when @media was a child rule
of another @-rule like @supports. Instead do the marking from the
consume method like we already did for @font-face rules.

Removed unnecessary marking from insertion methods and an unnecessary
boolean parameter which was always true.

R=timloh@chromium.org
BUG=621502
==========

to

==========
Mark stylesheet as having media queries at consume time.

Marking the stylesheet as having media queries for @media at insertion
time meant we didn't mark the stylesheet when @media was a child rule
of another @-rule like @supports. Instead do the marking from the
consume method like we already did for @font-face rules.

Removed unnecessary marking from insertion methods and an unnecessary
boolean parameter which was always true.

R=timloh@chromium.org
BUG=621502

Committed: https://crrev.com/feb31417375d9bd2cc2f383516c0485dc615286d
Cr-Commit-Position: refs/heads/master@{#402766}
==========

[commit-bot: I haz the power, 2016-06-29 10:11:54]

Patchset 4 (id:??) landed as
https://crrev.com/feb31417375d9bd2cc2f383516c0485dc615286d
Cr-Commit-Position: refs/heads/master@{#402766}