Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Side by Side Diff: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html

Issue 2081873008: Changed look of pin keyboard. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fixed patch set 1 errors. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!-- TODO(crbug.com/603217): Use i18n instead of string literals. Figure out 1 <!-- TODO(crbug.com/603217): Use i18n instead of string literals. Figure out
2 what i18n to use for keypad, ie, does 1 ABC make 2 what i18n to use for keypad, ie, does 1 ABC make
3 sense in every scenario? --> 3 sense in every scenario? -->
4 4
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/paper-styl es.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/paper-styl es.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">
9 9
10 <dom-module id="pin-keyboard"> 10 <dom-module id="pin-keyboard">
11 <template> 11 <template>
12 <style> 12 <style>
13 #root { 13 #root {
14 display: flex; 14 display: flex;
15 } 15 }
16 16
17 /* TODO(jdufault): Remove this CSS once we inline the PIN element with the
18 * user-pod. */
19 #container-constrained-width {
20 -webkit-tap-highlight-color: transparent;
21 background: white;
22 border-radius: 2px;
23 box-shadow: 0 4px 23px 5px rgba(0, 0, 0, 0.2),
24 0 2px 6px rgba(0, 0, 0, 0.15),
25 0 3px 0 rgba(0, 0, 0, 0.08);
26 cursor: pointer;
27 flex-direction: column;
28 outline: none;
29 }
30
31 .row { 17 .row {
32 display: flex; 18 display: flex;
33 } 19 }
34 20
35 .row.horizontal-center { 21 .row.horizontal-center {
36 justify-content: center; 22 justify-content: center;
37 } 23 }
38 24
39 .digit-button { 25 .digit-button {
40 align-items: center; 26 align-items: center;
41 background: none; 27 background: none;
42 border-radius: 50px; 28 border-radius: 50px;
29 box-sizing: border-box;
43 display: flex; 30 display: flex;
31 flex-direction: column;
44 font-size: 30px; 32 font-size: 30px;
33 height: 70px;
45 justify-content: center; 34 justify-content: center;
46 margin: 5px; 35 margin: 0;
47 min-width: 94px; 36 min-height: 70px;
48 width: 94px; 37 min-width: 85px;
38 padding: 15px 20px;
39 width: 85px;
40 }
41
42 .digit-button.clear-button {
43 display: block;
44 }
45
46 .digit-button .icon-div {
47 background: var(--paper-grey-500);
48 border-radius: 100px;
49 height: 24px;
50 margin: auto;
jdufault 2016/06/22 23:18:00 Is this needed?
sammiequon 2016/06/22 23:43:28 Yes.
51 width: 24px;
52 }
53
54 .digit-button .icon-div .icon {
55 color: white;
56 display: block;
jdufault 2016/06/22 23:18:00 Is display: block needed?
sammiequon 2016/06/22 23:43:28 Yes.
57 height: 16px;
58 left: 4px;
59 top: 4px;
60 width: 16px;
61 }
62
63 .digit-button .icon-text {
jdufault 2016/06/22 23:18:01 Can you please verify that all of the CSS here con
sammiequon 2016/06/22 23:43:28 Yes.
64 color: var(--paper-grey-500);
65 font-size: 10px;
66 padding: 10px;
67 text-transform: capitalize;
49 } 68 }
50 69
51 .digit-button inner-text { 70 .digit-button inner-text {
52 display: flex; 71 display: flex;
53 flex-direction: column; 72 flex-direction: column;
54 height: 52px; 73 height: 52px;
55 } 74 }
56 75
57 .digit-button inner-text subhead { 76 .first-row {
58 color: var(--paper-grey-500); 77 height: 54px;
59 font-size: 16px; 78 min-height: 54px;
60 }
61
62 .digit-button .submit-button {
63 background: var(--paper-blue-a400);
64 color: white;
65 font-size: 20px;
66 height: 60px;
67 min-width: 0;
68 width: 60px;
69 } 79 }
70 80
71 #pin-input { 81 #pin-input {
72 -webkit-text-security: disc; 82 -webkit-text-security: disc;
73 border-bottom-color: lightgray; 83 border: 0;
74 border-left: none;
75 border-right: none;
76 border-top: none;
77 font-size: 20px; 84 font-size: 20px;
78 height: 30px; 85 height: 54px;
79 margin-top: 10px;
80 text-align: center; 86 text-align: center;
81 width: 95%; 87 width: 75%;
jdufault 2016/06/22 23:18:00 Can you eliminate the % and use a margin/offset in
sammiequon 2016/06/22 23:43:28 Done.
82 } 88 }
83 89
84 #pin-input[type=number]::-webkit-inner-spin-button, 90 #pin-input[type=number]::-webkit-inner-spin-button,
85 #pin-input[type=number]::-webkit-outer-spin-button { 91 #pin-input[type=number]::-webkit-outer-spin-button {
86 -webkit-appearance: none; 92 -webkit-appearance: none;
87 margin: 0; 93 margin: 0;
88 } 94 }
89 95
90 /* Ensure that all children of paper-button do not consume events. This 96 /* Ensure that all children of paper-button do not consume events. This
91 * simplifies the event handler code. */ 97 * simplifies the event handler code. */
92 paper-button * { 98 paper-button * {
93 pointer-events: none; 99 pointer-events: none;
94 } 100 }
95 </style> 101 </style>
96 102
97 <div id="root"> 103 <div id="root">
98 <div id="container-constrained-width"> 104 <div id="container-constrained-width">
99 <div class="row horizontal-center"> 105 <div class="row horizontal-center">
100 <input id="pin-input" type="number" placeholder="Enter PIN" 106 <input id="pin-input" type="number" placeholder="Enter PIN"
101 on-keydown="onInputKeyDown_"></input> 107 on-keydown="onInputKeyDown_"></input>
108 <div class="digit-button first-row">
109 <paper-button class="digit-button submit-button"
110 on-tap="onPinSubmit_">
111 <div class="icon-div">
112 <iron-icon class="icon" icon="icons:forward"><iron-icon>
113 </div>
114 </paper-button>
115 </div>
102 </div> 116 </div>
103 117
104 <div class="row keyboard"> 118 <div class="row keyboard">
105 <paper-button class="digit-button" on-tap="onNumberTap_" value="1"> 119 <paper-button class="digit-button" on-tap="onNumberTap_" value="1">
106 <inner-text>1</inner-text> 120 <inner-text>1</inner-text>
107 </paper-button> 121 </paper-button>
108 <paper-button class="digit-button" on-tap="onNumberTap_" value="2"> 122 <paper-button class="digit-button" on-tap="onNumberTap_" value="2">
109 <inner-text>2<subhead>ABC</subhead></inner-text> 123 <inner-text>2</inner-text>
110 </paper-button> 124 </paper-button>
111 <paper-button class="digit-button" on-tap="onNumberTap_" value="3"> 125 <paper-button class="digit-button" on-tap="onNumberTap_" value="3">
112 <inner-text>3<subhead>DEF</subhead></inner-text> 126 <inner-text>3</inner-text>
113 </paper-button> 127 </paper-button>
114 </div> 128 </div>
115 <div class="row keyboard"> 129 <div class="row keyboard">
116 <paper-button class="digit-button" on-tap="onNumberTap_" value="4"> 130 <paper-button class="digit-button" on-tap="onNumberTap_" value="4">
117 <inner-text>4<subhead>GHI</subhead></inner-text> 131 <inner-text>4</inner-text>
118 </paper-button> 132 </paper-button>
119 <paper-button class="digit-button" on-tap="onNumberTap_" value="5"> 133 <paper-button class="digit-button" on-tap="onNumberTap_" value="5">
120 <inner-text>5<subhead>JKL</subhead></inner-text> 134 <inner-text>5</inner-text>
121 </paper-button> 135 </paper-button>
122 <paper-button class="digit-button" on-tap="onNumberTap_" value="6"> 136 <paper-button class="digit-button" on-tap="onNumberTap_" value="6">
123 <inner-text>6<subhead>MNO</subhead></inner-text> 137 <inner-text>6</inner-text>
124 </paper-button> 138 </paper-button>
125 </div> 139 </div>
126 <div class="row keyboard"> 140 <div class="row keyboard">
127 <paper-button class="digit-button" on-tap="onNumberTap_" value="7"> 141 <paper-button class="digit-button" on-tap="onNumberTap_" value="7">
128 <inner-text>7<subhead>PQRS</subhead></inner-text> 142 <inner-text>7</inner-text>
129 </paper-button> 143 </paper-button>
130 <paper-button class="digit-button" on-tap="onNumberTap_" value="8"> 144 <paper-button class="digit-button" on-tap="onNumberTap_" value="8">
131 <inner-text>8<subhead>TUV</subhead></inner-text> 145 <inner-text>8</inner-text>
132 </paper-button> 146 </paper-button>
133 <paper-button class="digit-button" on-tap="onNumberTap_" value="9"> 147 <paper-button class="digit-button" on-tap="onNumberTap_" value="9">
134 <inner-text>9<subhead>WXYZ</subhead></inner-text> 148 <inner-text>9</inner-text>
135 </paper-button> 149 </paper-button>
136 </div> 150 </div>
137 <div class="row keyboard"> 151 <div class="row keyboard">
138 <div class="digit-button"></div> 152 <div class="digit-button"></div>
139 <paper-button class="digit-button" on-tap="onNumberTap_" value="0"> 153 <paper-button class="digit-button" on-tap="onNumberTap_" value="0">
140 <inner-text>0</inner-text> 154 <inner-text>0</inner-text>
141 </paper-button> 155 </paper-button>
142 <div class="digit-button"> 156 <paper-button class="digit-button clear-button" on-tap="onPinClear_">
143 <paper-icon-button class="digit-button submit-button" 157 <div class="icon-div">
jdufault 2016/06/22 23:18:00 Is there a better class name than icon-div and ico
sammiequon 2016/06/22 23:43:28 Done.
144 icon="icons:check" on-tap="onPinSubmit_"> 158 <iron-icon class="icon" icon="icons:clear"><iron-icon>
145 </paper-icon-button> 159 </div>
146 </div> 160 <inner-text class="icon-text">Clear</inner-text>
161 </paper-button>
147 </div> 162 </div>
148 </div> 163 </div>
149 </div> 164 </div>
150 </template> 165 </template>
151 <script src="pin_keyboard.js"></script> 166 <script src="pin_keyboard.js"></script>
152 </dom-module> 167 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698