chrome/browser/ui/webui/help/help_browsertest.js - Issue 2081873002: Incorporate comments in Dbus code and add Eol icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/help/help_browsertest.js

Issue 2081873002: Incorporate comments in Dbus code and add Eol icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporate comments from UI review: Changed vector icons and UI strings. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/help/help_browsertest.js

diff --git a/chrome/browser/ui/webui/help/help_browsertest.js b/chrome/browser/ui/webui/help/help_browsertest.js

index bc92d5cbed973c5a9339c3dc1971d0fd0e6621d7..e11463d60f43fb90d9c3ae8b0355f181b22d85ac 100644

--- a/chrome/browser/ui/webui/help/help_browsertest.js

+++ b/chrome/browser/ui/webui/help/help_browsertest.js

@@ -125,17 +125,17 @@ TEST_F('HelpPageWebUITest', 'testRequestUpdate', function() {

// Test that the EndofLife String is shown and hidden properly.

TEST_F('HelpPageWebUITest', 'testUpdateEolMessage', function() {

- var container = $('update-status-container');

+ var updateStatusContainer = $('update-status-container');

var update = $('request-update');

- var message = $('eol-message');

+ var eolStatusContainer = $('eol-status-container');

help.HelpPage.updateEolMessage('device_supported', '');

- expectTrue(message.hidden);

+ expectTrue(eolStatusContainer.hidden);

help.HelpPage.updateEolMessage('device_endoflife', '');

- expectFalse(message.hidden);

+ expectFalse(eolStatusContainer.hidden);

expectTrue(update.disabled);

- expectTrue(container.hidden);

+ expectTrue(updateStatusContainer.hidden);

});

GEN('#endif');