Incorporate comments in Dbus code and add Eol icon

Follow up CL for EOL notification.
Incorporate comments in Dbus code and add Eol icon

BUG=611816
TEST=manual and browsertest
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1
Cr-Commit-Position: refs/heads/master@{#403319}

[xiaoyinh(OOO Sep 11-29), 2016-06-21 00:45:53]

Description was changed from

==========
Incorporate comments in Dbus code and add Eol icon

BUG=611816
TEST=manual and browsertest
==========

to

==========
Follow up CL for EOL notification.
Incorporate comments in Dbus code and add Eol icon

BUG=611816
TEST=manual and browsertest
==========

[xiaoyinh(OOO Sep 11-29), 2016-06-21 00:46:21]

xiaoyinh@chromium.org changed reviewers:
+ oshima@chromium.org, stevenjb@chromium.org, xiyuan@chromium.org

[hashimoto, 2016-06-21 03:09:50]

hashimoto@chromium.org changed reviewers:
+ hashimoto@chromium.org

[hashimoto, 2016-06-21 03:09:52]

https://codereview.chromium.org/2081873002/diff/1/chromeos/dbus/fake_update_e...
File chromeos/dbus/fake_update_engine_client.cc (right):

https://codereview.chromium.org/2081873002/diff/1/chromeos/dbus/fake_update_e...
chromeos/dbus/fake_update_engine_client.cc:78:
base::Bind(&FakeUpdateEngineClient::OnGetChannel,
This line does nothing.
If you want to run the callback asynchronously, it should be:

  base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, base::Bind(callback,
<callback argument>));

https://codereview.chromium.org/2081873002/diff/1/chromeos/dbus/fake_update_e...
chromeos/dbus/fake_update_engine_client.cc:84:
base::Bind(&FakeUpdateEngineClient::OnGetEolStatus,
ditto.

[oshima, 2016-06-21 06:19:15]

What hashimoto said, plus please specify who should review which directories
when you send CL to multiple reviewers.

[xiyuan, 2016-06-21 15:18:14]

https://codereview.chromium.org/2081873002/diff/1/ash/resources/ash_resources...
File ash/resources/ash_resources.grd (right):

https://codereview.chromium.org/2081873002/diff/1/ash/resources/ash_resources...
ash/resources/ash_resources.grd:167: <structure type="chrome_scaled_image"
name="IDR_AURA_NOTIFICATION_EOL"
file="cros/notification/eol_notification_icon.png" />
Why do we put this as part of ash resources? Since it is only used in Chrome,
probably a better place is theme_resources.grd.

https://codereview.chromium.org/2081873002/diff/1/chromeos/dbus/fake_update_e...
File chromeos/dbus/fake_update_engine_client.h (right):

https://codereview.chromium.org/2081873002/diff/1/chromeos/dbus/fake_update_e...
chromeos/dbus/fake_update_engine_client.h:80: void OnGetChannel(const
GetChannelCallback& callback) { callback.Run(""); }
Don't inline this. Put the body in cc file.

https://codereview.chromium.org/2081873002/diff/1/chromeos/dbus/fake_update_e...
chromeos/dbus/fake_update_engine_client.h:82: void OnGetEolStatus(const
GetEolStatusCallback& callback) {
same here.

[xiaoyinh(OOO Sep 11-29), 2016-06-22 18:25:40]

oshima@, Thank you for the advice. Could you help review changes in
chrome/app/theme?

xiyuan@, could you help review changes in
chrome/browser/chromeos/
chrome/browser/ui/webui/

stevenjb@,hashimoto@, Could you help review changes in
chromeos/dbus/

Thank you all!

https://codereview.chromium.org/2081873002/diff/1/ash/resources/ash_resources...
File ash/resources/ash_resources.grd (right):

https://codereview.chromium.org/2081873002/diff/1/ash/resources/ash_resources...
ash/resources/ash_resources.grd:167: <structure type="chrome_scaled_image"
name="IDR_AURA_NOTIFICATION_EOL"
file="cros/notification/eol_notification_icon.png" />
On 2016/06/21 15:18:14, xiyuan wrote:
> Why do we put this as part of ash resources? Since it is only used in Chrome,
> probably a better place is theme_resources.grd.

Moved to theme_resources.grd. Thanks!

https://codereview.chromium.org/2081873002/diff/1/chromeos/dbus/fake_update_e...
File chromeos/dbus/fake_update_engine_client.cc (right):

https://codereview.chromium.org/2081873002/diff/1/chromeos/dbus/fake_update_e...
chromeos/dbus/fake_update_engine_client.cc:78:
base::Bind(&FakeUpdateEngineClient::OnGetChannel,
On 2016/06/21 03:09:52, hashimoto wrote:
> This line does nothing.
> If you want to run the callback asynchronously, it should be:
> 
>   base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
base::Bind(callback,
> <callback argument>));

Thank you so much! Done.

https://codereview.chromium.org/2081873002/diff/1/chromeos/dbus/fake_update_e...
chromeos/dbus/fake_update_engine_client.cc:84:
base::Bind(&FakeUpdateEngineClient::OnGetEolStatus,
On 2016/06/21 03:09:52, hashimoto wrote:
> ditto.

Done.

https://codereview.chromium.org/2081873002/diff/1/chromeos/dbus/fake_update_e...
File chromeos/dbus/fake_update_engine_client.h (right):

https://codereview.chromium.org/2081873002/diff/1/chromeos/dbus/fake_update_e...
chromeos/dbus/fake_update_engine_client.h:80: void OnGetChannel(const
GetChannelCallback& callback) { callback.Run(""); }
On 2016/06/21 15:18:14, xiyuan wrote:
> Don't inline this. Put the body in cc file.

Done.

https://codereview.chromium.org/2081873002/diff/1/chromeos/dbus/fake_update_e...
chromeos/dbus/fake_update_engine_client.h:82: void OnGetEolStatus(const
GetEolStatusCallback& callback) {
On 2016/06/21 15:18:14, xiyuan wrote:
> same here.

Done.

[xiyuan, 2016-06-22 18:31:45]

lgtm

[xiaoyinh(OOO Sep 11-29), 2016-06-22 20:20:51]

Some trybots failed at compilation. Local compilation did succeed though.

Should I use this in the chrome code instead? 
#include "third_party/cros_system_api/dbus/service_constants.h"

[xiyuan, 2016-06-22 20:31:09]

On 2016/06/22 20:20:51, xiaoyinh wrote:
> Some trybots failed at compilation. Local compilation did succeed though.
> 
> Should I use this in the chrome code instead? 
> #include "third_party/cros_system_api/dbus/service_constants.h"

Seems like you need to wrap the include with  #if defined(OS_CHROMEOS).
version_update.h is shared across platforms.

[stevenjb, 2016-06-22 20:38:53]

lgtm

[xiaoyinh(OOO Sep 11-29), 2016-06-23 01:00:49]

On 2016/06/22 20:31:09, xiyuan wrote:
> On 2016/06/22 20:20:51, xiaoyinh wrote:
> > Some trybots failed at compilation. Local compilation did succeed though.
> > 
> > Should I use this in the chrome code instead? 
> > #include "third_party/cros_system_api/dbus/service_constants.h"
> 
> Seems like you need to wrap the include with  #if defined(OS_CHROMEOS).
> version_update.h is shared across platforms.

Thanks xiyuan, all the trybots passed now!

[hashimoto, 2016-06-23 05:12:48]

https://codereview.chromium.org/2081873002/diff/40001/chromeos/dbus/fake_upda...
File chromeos/dbus/fake_update_engine_client.cc (right):

https://codereview.chromium.org/2081873002/diff/40001/chromeos/dbus/fake_upda...
chromeos/dbus/fake_update_engine_client.cc:101: void
FakeUpdateEngineClient::OnGetChannel(const GetChannelCallback& callback) {
You don't need these methods and weak_ptr_factory_.

You should just base::Bind(callback, std::string()) and base::Bind(callback,
update_engine::EndOfLifeStatus::kSupported) instead.

[xiaoyinh(OOO Sep 11-29), 2016-06-23 14:54:50]

On 2016/06/23 05:12:48, hashimoto wrote:
>
https://codereview.chromium.org/2081873002/diff/40001/chromeos/dbus/fake_upda...
> File chromeos/dbus/fake_update_engine_client.cc (right):
> 
>
https://codereview.chromium.org/2081873002/diff/40001/chromeos/dbus/fake_upda...
> chromeos/dbus/fake_update_engine_client.cc:101: void
> FakeUpdateEngineClient::OnGetChannel(const GetChannelCallback& callback) {
> You don't need these methods and weak_ptr_factory_.
> 
> You should just base::Bind(callback, std::string()) and base::Bind(callback,
> update_engine::EndOfLifeStatus::kSupported) instead.

Got it, Thanks!
Changed.

[oshima, 2016-06-23 16:19:57]

can we use vector icon instead?

[xiaoyinh(OOO Sep 11-29), 2016-06-23 21:02:02]

xiaoyinh@chromium.org changed reviewers:
+ estade@chromium.org

[xiaoyinh(OOO Sep 11-29), 2016-06-23 21:02:03]

In this new patch:
1. Incorporated oshima@'s comment to add vector icon. 
estade@, could you help review it?
2. Add a new dismiss button to the notification, xiyuan@ could you help review
it?

Thank you!

[xiyuan, 2016-06-23 21:19:54]

https://codereview.chromium.org/2081873002/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/eol_notification.cc (right):

https://codereview.chromium.org/2081873002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:58: switch (button_index) {
Should we close the notification when either of the buttons is clicked? If so,
we need to explicitly call CancelById(). Otherwise, the notification just gets
hidden in the message center.

[hashimoto, 2016-06-24 00:06:45]

chromeos/dbus lgtm

[xiaoyinh(OOO Sep 11-29), 2016-06-24 00:41:17]

On 2016/06/23 21:19:54, xiyuan wrote:
>
https://codereview.chromium.org/2081873002/diff/80001/chrome/browser/chromeos...
> File chrome/browser/chromeos/eol_notification.cc (right):
> 
>
https://codereview.chromium.org/2081873002/diff/80001/chrome/browser/chromeos...
> chrome/browser/chromeos/eol_notification.cc:58: switch (button_index) {
> Should we close the notification when either of the buttons is clicked? If so,
> we need to explicitly call CancelById(). Otherwise, the notification just gets
> hidden in the message center.

Done.

[xiyuan, 2016-06-24 01:00:22]

lgtm

[xiaoyinh(OOO Sep 11-29), 2016-06-24 15:38:54]

The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 15:39:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 16:45:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 16:45:09]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[xiaoyinh(OOO Sep 11-29), 2016-06-29 22:00:08]

Description was changed from

==========
Follow up CL for EOL notification.
Incorporate comments in Dbus code and add Eol icon

BUG=611816
TEST=manual and browsertest
==========

to

==========
Follow up CL for EOL notification.
Incorporate comments in Dbus code and add Eol icon

BUG=611816
TEST=manual and browsertest
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[xiaoyinh(OOO Sep 11-29), 2016-06-29 22:12:49]

Patch 7 incoporate comment from UI review, which is including front end
modification, new vector icons.  
xiyuan@, could you help review the changes in UI side?
estade@, could you help review the new vector icons?

Thank you very much!

[Evan Stade, 2016-06-29 22:22:19]

https://codereview.chromium.org/2081873002/diff/120001/ui/gfx/vector_icons/eo...
File ui/gfx/vector_icons/eol.1x.icon (right):

https://codereview.chromium.org/2081873002/diff/120001/ui/gfx/vector_icons/eo...
ui/gfx/vector_icons/eol.1x.icon:5: CANVAS_DIMENSIONS, 160,
this doesn't make sense --- the 1x version shouldn't be twice the size of the
normal version. Also you shouldn't need a 1x version when the icon is this huge
(it's really only for tweaking tiny icons).

https://codereview.chromium.org/2081873002/diff/120001/ui/gfx/vector_icons/in...
File ui/gfx/vector_icons/info.icon (right):

https://codereview.chromium.org/2081873002/diff/120001/ui/gfx/vector_icons/in...
ui/gfx/vector_icons/info.icon:1: // Copyright 2016 The Chromium Authors. All
rights reserved.
is this ic_info from go/icons?

https://codereview.chromium.org/2081873002/diff/120001/ui/gfx/vector_icons/no...
File ui/gfx/vector_icons/notification_off.icon (right):

https://codereview.chromium.org/2081873002/diff/120001/ui/gfx/vector_icons/no...
ui/gfx/vector_icons/notification_off.icon:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
is this ic_notifications_off from go/icons? If so, you left off an 's' in the
file name.

[xiyuan, 2016-06-29 22:29:37]

https://codereview.chromium.org/2081873002/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/help/help_content.css (right):

https://codereview.chromium.org/2081873002/diff/120001/chrome/browser/resourc...
chrome/browser/resources/help/help_content.css:112: margin-left: 12px;
margin-left is not RTL friendly. Let's use "-webkit-margin-start" instead.

And move "-webkit-margin-start" to beginning of the rules to keep it alpha
sorted.

https://codereview.chromium.org/2081873002/diff/120001/chrome/browser/resourc...
chrome/browser/resources/help/help_content.css:118: margin-left: 12px;
ditto

https://codereview.chromium.org/2081873002/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/help/help_content.html (right):

https://codereview.chromium.org/2081873002/diff/120001/chrome/browser/resourc...
chrome/browser/resources/help/help_content.html:52: <div id
="eol-message"></div>
nit: strip space before and after "="

https://codereview.chromium.org/2081873002/diff/120001/chrome/browser/resourc...
chrome/browser/resources/help/help_content.html:53: <div id = "eol-learnMore"
i18n-content="eolLearnMore"></div>
ditto

[xiaoyinh(OOO Sep 11-29), 2016-06-29 23:25:56]

https://codereview.chromium.org/2081873002/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/help/help_content.css (right):

https://codereview.chromium.org/2081873002/diff/120001/chrome/browser/resourc...
chrome/browser/resources/help/help_content.css:112: margin-left: 12px;
On 2016/06/29 22:29:37, xiyuan wrote:
> margin-left is not RTL friendly. Let's use "-webkit-margin-start" instead.
> 
> And move "-webkit-margin-start" to beginning of the rules to keep it alpha
> sorted.

Done.

https://codereview.chromium.org/2081873002/diff/120001/chrome/browser/resourc...
chrome/browser/resources/help/help_content.css:118: margin-left: 12px;
On 2016/06/29 22:29:37, xiyuan wrote:
> ditto

Done.

https://codereview.chromium.org/2081873002/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/help/help_content.html (right):

https://codereview.chromium.org/2081873002/diff/120001/chrome/browser/resourc...
chrome/browser/resources/help/help_content.html:52: <div id
="eol-message"></div>
On 2016/06/29 22:29:37, xiyuan wrote:
> nit: strip space before and after "="

Done.

https://codereview.chromium.org/2081873002/diff/120001/chrome/browser/resourc...
chrome/browser/resources/help/help_content.html:53: <div id = "eol-learnMore"
i18n-content="eolLearnMore"></div>
On 2016/06/29 22:29:37, xiyuan wrote:
> ditto

Done.

https://codereview.chromium.org/2081873002/diff/120001/ui/gfx/vector_icons/eo...
File ui/gfx/vector_icons/eol.1x.icon (right):

https://codereview.chromium.org/2081873002/diff/120001/ui/gfx/vector_icons/eo...
ui/gfx/vector_icons/eol.1x.icon:5: CANVAS_DIMENSIONS, 160,
On 2016/06/29 22:22:19, Evan Stade wrote:
> this doesn't make sense --- the 1x version shouldn't be twice the size of the
> normal version. Also you shouldn't need a 1x version when the icon is this
huge
> (it's really only for tweaking tiny icons).

Thank you for the explanation. Removed.

https://codereview.chromium.org/2081873002/diff/120001/ui/gfx/vector_icons/in...
File ui/gfx/vector_icons/info.icon (right):

https://codereview.chromium.org/2081873002/diff/120001/ui/gfx/vector_icons/in...
ui/gfx/vector_icons/info.icon:1: // Copyright 2016 The Chromium Authors. All
rights reserved.
On 2016/06/29 22:22:19, Evan Stade wrote:
> is this ic_info from go/icons?

This is ic_info_outline. I changed the name accordingly.

https://codereview.chromium.org/2081873002/diff/120001/ui/gfx/vector_icons/no...
File ui/gfx/vector_icons/notification_off.icon (right):

https://codereview.chromium.org/2081873002/diff/120001/ui/gfx/vector_icons/no...
ui/gfx/vector_icons/notification_off.icon:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
On 2016/06/29 22:22:19, Evan Stade wrote:
> is this ic_notifications_off from go/icons? If so, you left off an 's' in the
> file name.

Changed. Thanks.

[xiyuan, 2016-06-30 00:19:56]

lgtm

[stevenjb, 2016-06-30 00:21:22]

chromeos/ lgtm

[Evan Stade, 2016-06-30 13:41:42]

lgtm

https://codereview.chromium.org/2081873002/diff/160001/ui/webui/resources/ima...
File ui/webui/resources/images/eol.svg (right):

https://codereview.chromium.org/2081873002/diff/160001/ui/webui/resources/ima...
ui/webui/resources/images/eol.svg:3: <!-- Generator: Sketch 3.8.3 (29802) -
http://www.bohemiancoding.com/sketch -->
has this been run through svgo? Comments and descriptions and such shouldn't be
necessary to keep around

[xiaoyinh(OOO Sep 11-29), 2016-06-30 16:16:20]

https://codereview.chromium.org/2081873002/diff/160001/ui/webui/resources/ima...
File ui/webui/resources/images/eol.svg (right):

https://codereview.chromium.org/2081873002/diff/160001/ui/webui/resources/ima...
ui/webui/resources/images/eol.svg:3: <!-- Generator: Sketch 3.8.3 (29802) -
http://www.bohemiancoding.com/sketch -->
On 2016/06/30 13:41:42, Evan Stade wrote:
> has this been run through svgo? Comments and descriptions and such shouldn't
be
> necessary to keep around

Done.

[xiaoyinh(OOO Sep 11-29), 2016-06-30 16:16:46]

The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 16:17:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiaoyinh(OOO Sep 11-29), 2016-06-30 16:18:36]

The CQ bit was unchecked by xiaoyinh@chromium.org

[xiaoyinh(OOO Sep 11-29), 2016-06-30 19:45:24]

xiaoyinh@chromium.org changed reviewers:
+ isherman@chromium.org

[xiaoyinh(OOO Sep 11-29), 2016-06-30 19:45:25]

isherman@, could you take a look at histograms.xml?
xiyuan@, could you help review help_browsertest.js?

Thanks!

[xiaoyinh(OOO Sep 11-29), 2016-06-30 19:45:48]

The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 19:46:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-06-30 20:02:42]

help_browsertest.js lgtm

https://codereview.chromium.org/2081873002/diff/200001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/help/help_browsertest.js (right):

https://codereview.chromium.org/2081873002/diff/200001/chrome/browser/ui/webu...
chrome/browser/ui/webui/help/help_browsertest.js:22: 
nit: undo this, no empty line needed before closing "}" unless there is one
following the opening "{".

[xiaoyinh(OOO Sep 11-29), 2016-06-30 20:31:53]

https://codereview.chromium.org/2081873002/diff/200001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/help/help_browsertest.js (right):

https://codereview.chromium.org/2081873002/diff/200001/chrome/browser/ui/webu...
chrome/browser/ui/webui/help/help_browsertest.js:22: 
On 2016/06/30 20:02:42, xiyuan wrote:
> nit: undo this, no empty line needed before closing "}" unless there is one
> following the opening "{".

Done.

[Ilya Sherman, 2016-06-30 21:02:49]

histograms.xml lgtm % a nit:

https://codereview.chromium.org/2081873002/diff/220001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2081873002/diff/220001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:80979: -  <int value="581118445"
label="enable-eol-notification"/>
nit: Please leave this entry in place, so that old data remain interpretable as
well.

[xiaoyinh(OOO Sep 11-29), 2016-06-30 21:35:28]

https://codereview.chromium.org/2081873002/diff/220001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2081873002/diff/220001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:80979: -  <int value="581118445"
label="enable-eol-notification"/>
On 2016/06/30 21:02:49, Ilya Sherman wrote:
> nit: Please leave this entry in place, so that old data remain interpretable
as
> well.

Done.

[xiaoyinh(OOO Sep 11-29), 2016-06-30 21:36:11]

The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 21:37:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 22:48:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 22:48:53]

Dry run: This issue passed the CQ dry run.

[xiaoyinh(OOO Sep 11-29), 2016-06-30 22:49:18]

The CQ bit was checked by xiaoyinh@chromium.org

[xiaoyinh(OOO Sep 11-29), 2016-06-30 22:49:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
hashimoto@chromium.org, stevenjb@chromium.org, estade@chromium.org,
xiyuan@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2081873002/#ps240001
(title: "incorporate comments from isherman@")

[commit-bot: I haz the power, 2016-06-30 22:50:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 22:56:24]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-06-30 22:56:38]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 22:58:40]

Description was changed from

==========
Follow up CL for EOL notification.
Incorporate comments in Dbus code and add Eol icon

BUG=611816
TEST=manual and browsertest
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Follow up CL for EOL notification.
Incorporate comments in Dbus code and add Eol icon

BUG=611816
TEST=manual and browsertest
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1
Cr-Commit-Position: refs/heads/master@{#403319}
==========

[commit-bot: I haz the power, 2016-06-30 22:58:42]

Patchset 13 (id:??) landed as
https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1
Cr-Commit-Position: refs/heads/master@{#403319}