Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2081853004: Do not use Dart_DefaultCanonicalizeUrl for resolving a script uri in the current working directory … (Closed)

Created:
4 years, 6 months ago by siva
Modified:
4 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not use Dart_DefaultCanonicalizeUrl for resolving a script uri in the current working directory as that code has not been written to handle paths on windows. Committed: https://github.com/dart-lang/sdk/commit/d41d5dc414bec844d755d017000780c4eec0725d

Patch Set 1 #

Patch Set 2 : Do not use Dart_DefaultCanonicalizeUrl for resolving a script uri in the current working directory … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M runtime/bin/dartutils.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 3 chunks +29 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
TBR=johnmccutchan
4 years, 6 months ago (2016-06-21 02:59:39 UTC) #2
siva
Committed patchset #2 (id:20001) manually as d41d5dc414bec844d755d017000780c4eec0725d (presubmit successful).
4 years, 6 months ago (2016-06-21 03:00:00 UTC) #4
Cutch
lgtm
4 years, 6 months ago (2016-06-21 13:52:56 UTC) #5
Cutch
4 years, 6 months ago (2016-06-21 19:57:32 UTC) #6
Message was sent while issue was closed.
On 2016/06/21 13:52:56, Cutch wrote:
> lgtm

I think the Dart code replaces '\'s with '/'s before passing it to the Uri
class.

Powered by Google App Engine
This is Rietveld 408576698