Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2081833002: Remove dependency of content/browser/loader/power_save_block_resource_throttle.cc on browser_thread… (Closed)

Created:
4 years, 6 months ago by scottmg
Modified:
4 years, 6 months ago
Reviewers:
mmenke
CC:
chromium-reviews, loading-reviews_chromium.org, darin-cc_chromium.org, jam, Randy Smith (Not in Mondays)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency of content/browser/loader/power_save_block_resource_throttle.cc on browser_thread.h R=mmenke@chromium.org BUG=612563 Committed: https://crrev.com/9608e2cea5b14c1b7a4b2cc0b2e938356f61b0da Cr-Commit-Position: refs/heads/master@{#401023}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M content/browser/loader/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/loader/power_save_block_resource_throttle.h View 3 chunks +9 lines, -1 line 0 comments Download
M content/browser/loader/power_save_block_resource_throttle.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
scottmg
4 years, 6 months ago (2016-06-20 23:03:11 UTC) #1
mmenke
LGTM
4 years, 6 months ago (2016-06-21 15:34:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081833002/20001
4 years, 6 months ago (2016-06-21 16:36:37 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 17:18:41 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9608e2cea5b14c1b7a4b2cc0b2e938356f61b0da Cr-Commit-Position: refs/heads/master@{#401023}
4 years, 6 months ago (2016-06-21 17:49:34 UTC) #7
Peter Mayo
On 2016/06/21 17:49:34, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
4 years, 6 months ago (2016-06-21 19:44:19 UTC) #8
scottmg
4 years, 6 months ago (2016-06-21 19:47:41 UTC) #9
Message was sent while issue was closed.
On 2016/06/21 19:44:19, Peter Mayo wrote:
> On 2016/06/21 17:49:34, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/9608e2cea5b14c1b7a4b2cc0b2e938356f61b0da
> > Cr-Commit-Position: refs/heads/master@{#401023}
> 
> I don't see how, but could this CL have caused
>
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...
> 
> 
> It is the most likely I can see in:
>
https://chromium.googlesource.com/chromium/src/+log/ba6d6a649dd1db1125dc6b321...

It doesn't seem likely to me, but feel free to try a trial revert if you'd like.

Powered by Google App Engine
This is Rietveld 408576698