Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2081753002: Motown: Stop requiring size when releasing payload buffers. (Closed)

Created:
4 years, 6 months ago by dalesat
Modified:
4 years, 6 months ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Motown: Stop requiring size when releasing payload buffers. PayloadAllocator and related classes in Motown have required the size of a payload buffer to be specified on release. This was done to check for agreement with the allocation. Providing the size on release isn't always convenient. In getting video to work, a case has come up in which the added code complexity required to provide the size parameter is too high a penalty to pay for the small increment in safety. R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/eee3400dfcd3fed6bf87f5abb2e58fc0b2ccac42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M mojo/services/media/common/cpp/fifo_allocator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/media/common/cpp/fifo_allocator.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M mojo/services/media/common/cpp/shared_media_buffer_allocator.h View 2 chunks +4 lines, -4 lines 0 comments Download
M services/media/framework/packet.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework/payload_allocator.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework/payload_allocator.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M services/media/framework_ffmpeg/ffmpeg_decoder_base.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework_mojo/mojo_allocator.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework_mojo/mojo_allocator.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dalesat
Please take a look. Thanks!
4 years, 6 months ago (2016-06-20 15:57:06 UTC) #3
kulakowski
lgtm
4 years, 6 months ago (2016-06-20 16:56:39 UTC) #4
dalesat
4 years, 6 months ago (2016-06-20 17:48:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eee3400dfcd3fed6bf87f5abb2e58fc0b2ccac42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698