Rip out most of our outdated modules implementation.

Rip out most of our outdated modules implementation.

R=adamk@chromium.org
BUG=

Committed: https://crrev.com/41f5f0c0ba8fde596af2a9e75ea8438edf7c64b2
Cr-Commit-Position: refs/heads/master@{#37311}

[neis, 2016-06-21 13:45:28]

Description was changed from

==========
Rip out most of our outdated modules implementation.

R=adamk@chromium.org
BUG=
==========

to

==========
Rip out most of our outdated modules implementation.

R=adamk@chromium.org
BUG=
==========

[neis, 2016-06-21 13:45:28]

neis@chromium.org changed reviewers:
+ jarin@chromium.org

[neis, 2016-06-21 13:45:44]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 13:45:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081733004/20001

[neis, 2016-06-21 13:55:23]

Hold on, I've found a few leftovers.

[commit-bot: I haz the power, 2016-06-21 14:17:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 14:17:34]

Dry run: This issue passed the CQ dry run.

[neis, 2016-06-21 14:37:56]

PTAL. Most of the parser code remains, as well as a few runtime components. Some
of these may be removed at a later point.

[Jarin, 2016-06-21 14:52:17]

lgtm for the various compiler parts of this CL.

[rmcilroy, 2016-06-21 15:02:37]

lgtm on interpreter

[adamk, 2016-06-21 17:04:07]

lgtm with one question

https://codereview.chromium.org/2081733004/diff/40001/src/ast/scopes.cc
File src/ast/scopes.cc (left):

https://codereview.chromium.org/2081733004/diff/40001/src/ast/scopes.cc#oldco...
src/ast/scopes.cc:230: } else if (context->IsModuleContext()) {
Is this really dead yet? It appears that ModuleContexts are still a thing, they
just contain less stuff. Did you want to remove more from contexts.h?

[neis, 2016-06-27 09:19:06]

On 2016/06/21 17:04:07, adamk wrote:
> lgtm with one question
> 
> https://codereview.chromium.org/2081733004/diff/40001/src/ast/scopes.cc
> File src/ast/scopes.cc (left):
> 
>
https://codereview.chromium.org/2081733004/diff/40001/src/ast/scopes.cc#oldco...
> src/ast/scopes.cc:230: } else if (context->IsModuleContext()) {
> Is this really dead yet? It appears that ModuleContexts are still a thing,
they
> just contain less stuff. Did you want to remove more from contexts.h?

It's probably dead but you're right that it's more consistent to leave it in for
now as long as these contexts still exist.

[neis, 2016-06-27 11:57:21]

Patchset #4 (id:60001) has been deleted

[neis, 2016-06-27 11:57:34]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 11:57:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 11:59:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 11:59:15]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/7992)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/7975)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/7952)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/3899)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18080)

[neis, 2016-06-27 12:10:35]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 12:10:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2016-06-27 12:19:31]

On 2016/06/27 09:19:06, neis wrote:
> On 2016/06/21 17:04:07, adamk wrote:
> > lgtm with one question
> > 
> > https://codereview.chromium.org/2081733004/diff/40001/src/ast/scopes.cc
> > File src/ast/scopes.cc (left):
> > 
> >
>
https://codereview.chromium.org/2081733004/diff/40001/src/ast/scopes.cc#oldco...
> > src/ast/scopes.cc:230: } else if (context->IsModuleContext()) {
> > Is this really dead yet? It appears that ModuleContexts are still a thing,
> they
> > just contain less stuff. Did you want to remove more from contexts.h?
> 
> It's probably dead but you're right that it's more consistent to leave it in
for
> now as long as these contexts still exist.

Okay, I had to remove that because it doesn't compile anymore.  The DCHECK in
the last case ensures that it's dead code.  I wanted to remove module contexts
completely but it got a bit messy so I'd like to land this first.  Are you okay
with that?

[commit-bot: I haz the power, 2016-06-27 12:41:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 12:41:27]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-06-27 18:23:22]

On 2016/06/27 12:19:31, neis wrote:
> On 2016/06/27 09:19:06, neis wrote:
> > On 2016/06/21 17:04:07, adamk wrote:
> > > lgtm with one question
> > > 
> > > https://codereview.chromium.org/2081733004/diff/40001/src/ast/scopes.cc
> > > File src/ast/scopes.cc (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/2081733004/diff/40001/src/ast/scopes.cc#oldco...
> > > src/ast/scopes.cc:230: } else if (context->IsModuleContext()) {
> > > Is this really dead yet? It appears that ModuleContexts are still a thing,
> > they
> > > just contain less stuff. Did you want to remove more from contexts.h?
> > 
> > It's probably dead but you're right that it's more consistent to leave it in
> for
> > now as long as these contexts still exist.
> 
> Okay, I had to remove that because it doesn't compile anymore.  The DCHECK in
> the last case ensures that it's dead code.  I wanted to remove module contexts
> completely but it got a bit messy so I'd like to land this first.  Are you
okay
> with that?

lgtm to land with it removed, I'll bet lazy compilation is already busted for
modules for other reasons.

[adamk, 2016-06-27 18:23:34]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-06-27 18:23:34]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org,
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2081733004/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-06-27 18:23:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 18:28:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 18:28:09]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18123)

[neis, 2016-06-28 07:11:48]

neis@chromium.org changed reviewers:
+ ahaas@chromium.org

[neis, 2016-06-28 07:12:12]

On 2016/06/27 18:28:09, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18123)

+ahaas for wasm

[ahaas, 2016-06-28 07:15:57]

On 2016/06/28 at 07:12:12, neis wrote:
> On 2016/06/27 18:28:09, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
> > http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18123)
> 
> +ahaas for wasm

wasm lgtm

[neis, 2016-06-28 07:16:36]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-06-28 07:16:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 07:22:56]

Description was changed from

==========
Rip out most of our outdated modules implementation.

R=adamk@chromium.org
BUG=
==========

to

==========
Rip out most of our outdated modules implementation.

R=adamk@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-06-28 07:22:58]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-06-28 07:25:49]

Description was changed from

==========
Rip out most of our outdated modules implementation.

R=adamk@chromium.org
BUG=
==========

to

==========
Rip out most of our outdated modules implementation.

R=adamk@chromium.org
BUG=

Committed: https://crrev.com/41f5f0c0ba8fde596af2a9e75ea8438edf7c64b2
Cr-Commit-Position: refs/heads/master@{#37311}
==========

[commit-bot: I haz the power, 2016-06-28 07:25:51]

Patchset 4 (id:??) landed as
https://crrev.com/41f5f0c0ba8fde596af2a9e75ea8438edf7c64b2
Cr-Commit-Position: refs/heads/master@{#37311}