src/messages.cc - Issue 2081733002: [keys] support shadowing keys in the KeyAccumulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.cc

Issue 2081733002: [keys] support shadowing keys in the KeyAccumulator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebasing Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/messages.cc

diff --git a/src/messages.cc b/src/messages.cc

index 0dffbb4dab13ca5dc97e417634597118d048ca3f..3bd60492e34e38ba748042932111a695cdaa9329 100644

--- a/src/messages.cc

+++ b/src/messages.cc

@@ -286,7 +286,7 @@ Handle<Object> CallSite::GetMethodName() {

Handle<JSObject> current_obj = Handle<JSObject>::cast(current);

if (current_obj->IsAccessCheckNeeded()) break;

Handle<FixedArray> keys =

- KeyAccumulator::GetEnumPropertyKeys(isolate_, current_obj);

+ KeyAccumulator::GetOwnEnumPropertyKeys(isolate_, current_obj);

for (int i = 0; i < keys->length(); i++) {

HandleScope inner_scope(isolate_);

if (!keys->get(i)->IsName()) continue;

« no previous file with comments | « src/keys.cc ('k') | src/objects.h » ('j') | no next file with comments »