Move Event to oilpan's heap

Move Event to oilpan's heap

Now there is no test failing when I change RefCounted<Event> to RefCountedGarbageCollected<Event>. Thus this CL does the change.

BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169941

[haraken, 2014-03-25 09:54:36]

PTAL

Mads: As you mentioned, I confirmed that several worker-related tests sometimes
hit assertions in debug mode (but they are not treated as crashes). However, I
found that these failures are flaky and already happening in trunk. I cannot
find any new assertion failures introduced by making Event
RefCountedGarbageCollected. So I think it's now OK to make this change.

[wibling-chromium, 2014-03-25 11:48:46]

lgtm

[Mads Ager (chromium), 2014-03-25 12:18:39]

LGTM

Let's give it a spin. If we already have threading asserts in debug mode worker
tests we need to look into those and get the resolved.

[haraken, 2014-03-25 12:22:06]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-03-25 12:22:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/208173004/20001

[commit-bot: I haz the power, 2014-03-25 13:23:31]

Change committed as 169941

[sof, 2014-03-25 14:44:00]

good, it's back on :)

What's the plan, let it settle in a bit before translating the persistents etc.
on the individual Events?

[haraken, 2014-03-25 15:26:21]

On 2014/03/25 14:44:00, sof wrote:
> good, it's back on :)
> 
> What's the plan, let it settle in a bit before translating the persistents
etc.
> on the individual Events?

Yes. I'll make the change to change persistents in events to members tomorrow :)

[sof, 2014-03-25 16:30:35]

On 2014/03/25 15:26:21, haraken wrote:
> On 2014/03/25 14:44:00, sof wrote:
> > good, it's back on :)
> > 
> > What's the plan, let it settle in a bit before translating the persistents
> etc.
> > on the individual Events?
> 
> Yes. I'll make the change to change persistents in events to members tomorrow
:)

Great; the GC plugin picks out a number of them :)

[haraken, 2014-03-26 02:37:36]

After landing this CL, the following tests started to fail flakily:

fast/dom/inline-event-attributes-release.html
http/tests/media/media-source/webkitmediasource-closed-on-htmlmediaelement-destruction.html
svg/animations/smil-leak-element-instances-noBaseValRef.svg
svg/animations/smil-leak-element-instances.svg
svg/animations/smil-leak-elements.svg

I'm not planning to revert this CL, because the number of failing tests are not
many (I'll fix them in a reasonable timeline) and because I want to get a list
of flaky tests caused by moving Event to oilpan's heap.

[kouhei (in TOK), 2014-03-26 03:13:41]

> svg/animations/smil-leak-element-instances-noBaseValRef.svg
> svg/animations/smil-leak-element-instances.svg
> svg/animations/smil-leak-elements.svg
Looking into these.

[kouhei (in TOK), 2014-03-26 03:28:04]

>
http/tests/media/media-source/webkitmediasource-closed-on-htmlmediaelement-destruction.html
Now looking into this.

[enne (OOO), 2014-03-26 20:17:16]

A revert of this CL has been created in
https://codereview.chromium.org/213403004/ by enne@chromium.org.

The reason for reverting is: Seems likely to have caused a number of flaky
failures in layout tests in oilpan builds:

Flakiness dashboard link:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...

Example failure bot:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/...

Example failure:
---
/mnt/data/b/build/slave/WebKit_Linux_Oilpan/build/layout-test-results/svg/animations/smil-leak-element-instances-noBaseValRef-expected.txt
+++
/mnt/data/b/build/slave/WebKit_Linux_Oilpan/build/layout-test-results/svg/animations/smil-leak-element-instances-noBaseValRef-actual.txt
@@ -1 +1 @@
-PASS
+FAIL: -3 extra live node(s)


.