Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: net/quic/spdy_utils.cc

Issue 2081713006: gfe-relnote: Fix an error in QUIC's SpdyUtils where content-length was (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a bug in QUIC's SpdyUtils where >4GB content-lengths failed to parse. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/spdy_utils_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/spdy_utils.cc
diff --git a/net/quic/spdy_utils.cc b/net/quic/spdy_utils.cc
index 9f12ef5826d27e89faedb2f007eb349d65d0d88c..0b74cb6f69de66410b3589378b284bc1ef48520c 100644
--- a/net/quic/spdy_utils.cc
+++ b/net/quic/spdy_utils.cc
@@ -145,8 +145,8 @@ bool SpdyUtils::CopyAndValidateHeaders(const QuicHeaderList& header_list,
base::SplitString(content_length_header, base::StringPiece("\0", 1),
base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
for (const string& value : values) {
- int new_value;
- if (!base::StringToInt(value, &new_value) || new_value < 0) {
+ int64_t new_value;
+ if (!base::StringToInt64(value, &new_value) || new_value < 0) {
DLOG(ERROR) << "Content length was either unparseable or negative.";
return false;
}
« no previous file with comments | « no previous file | net/quic/spdy_utils_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698