Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2081713002: Remove Crashpad from chrome_elf sources. (Closed)

Created:
4 years, 6 months ago by chrisha
Modified:
4 years, 6 months ago
CC:
chromium-reviews, caitkp+watch_chromium.org, ananta
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Crashpad from chrome_elf sources. This fixes the win-asan build, which has been offline since https://crrev.com/f265187bf390845c6d353fa7c4a9a72575fd86dd This is a partial revert of https://codereview.chromium.org/2053953002/ TBR=caitkp@chromium.org BUG=621460 Committed: https://crrev.com/f546a78ac6eb865d418defe38cf70c1f0e3988c0 Cr-Commit-Position: refs/heads/master@{#400685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M chrome_elf/BUILD.gn View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome_elf/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_elf/chrome_elf.gyp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
chrisha
PTAL?
4 years, 6 months ago (2016-06-20 13:47:19 UTC) #3
Sigurður Ásgeirsson
LGTM
4 years, 6 months ago (2016-06-20 13:49:33 UTC) #4
Sébastien Marchand
lgtm
4 years, 6 months ago (2016-06-20 14:05:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081713002/1
4 years, 6 months ago (2016-06-20 14:11:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/203277)
4 years, 6 months ago (2016-06-20 14:17:50 UTC) #10
chrisha
caitkp: PTAL for chrome_elf?
4 years, 6 months ago (2016-06-20 14:19:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081713002/1
4 years, 6 months ago (2016-06-20 14:19:57 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 15:39:40 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 15:43:16 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f546a78ac6eb865d418defe38cf70c1f0e3988c0
Cr-Commit-Position: refs/heads/master@{#400685}

Powered by Google App Engine
This is Rietveld 408576698