Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2081663004: X87: Avoid creating weak cells for literal arrays that are empty of literals. (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Avoid creating weak cells for literal arrays that are empty of literals. port 3cfcc7e111a32f231a483b8feda19ef2d8c45253 (r36786) original commit message: It may be that we have a feedback vector, but no literals. In this case we can store into the OptimizedCodeMap directly instead of using a WeakCell, because all data in the feedback vector is already held weakly. The use of a WeakCell in the OptimizedCodeMap is only required when there are literals which may hold maps strongly. This is to address a performance regression caused by the creation of a large number of WeakCells. BUG= Committed: https://crrev.com/eef939b4aaf0de0eae2382ae3015e660f3b19c27 Cr-Commit-Position: refs/heads/master@{#37123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M src/x87/builtins-x87.cc View 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-21 02:06:46 UTC) #2
Weiliang
lgtm
4 years, 6 months ago (2016-06-21 02:55:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081663004/1
4 years, 6 months ago (2016-06-21 05:19:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 05:40:47 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 05:42:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eef939b4aaf0de0eae2382ae3015e660f3b19c27
Cr-Commit-Position: refs/heads/master@{#37123}

Powered by Google App Engine
This is Rietveld 408576698