Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Issue 2081663002: Add a few extra tests for throttling corner cases (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/scheduler/renderer/throttling_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
diff --git a/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc b/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
index 11e810cb2a4ece99077ce32578aeecc96afa64c7..9cbe46db50fbb435084b07bb5ee692ce66ce4829 100644
--- a/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
+++ b/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
@@ -2141,6 +2141,30 @@ TEST_F(RendererSchedulerImplTest, SuspendAndResumeTimerQueue) {
testing::ElementsAre(std::string("T1"), std::string("T2")));
}
+TEST_F(RendererSchedulerImplTest, SuspendAndThrottleTimerQueue) {
+ std::vector<std::string> run_order;
+ PostTestTasks(&run_order, "T1 T2");
+
+ scheduler_->SuspendTimerQueue();
+ RunUntilIdle();
+ scheduler_->throttling_helper()->IncreaseThrottleRefCount(
+ static_cast<TaskQueue*>(timer_task_runner_.get()));
+ RunUntilIdle();
+ EXPECT_TRUE(run_order.empty());
+}
+
+TEST_F(RendererSchedulerImplTest, ThrottleAndSuspendTimerQueue) {
+ std::vector<std::string> run_order;
+ PostTestTasks(&run_order, "T1 T2");
+
+ scheduler_->throttling_helper()->IncreaseThrottleRefCount(
+ static_cast<TaskQueue*>(timer_task_runner_.get()));
+ RunUntilIdle();
+ scheduler_->SuspendTimerQueue();
+ RunUntilIdle();
+ EXPECT_TRUE(run_order.empty());
+}
+
TEST_F(RendererSchedulerImplTest, MultipleSuspendsNeedMultipleResumes) {
std::vector<std::string> run_order;
PostTestTasks(&run_order, "T1 T2");
« no previous file with comments | « no previous file | components/scheduler/renderer/throttling_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698