Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2081653005: X87: [builtins] Introduce proper base::ieee754::log. (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Introduce proper base::ieee754::log. port d0c7775d7cfec5ae628ab9f3f00cff09b01930ac(r36880) original commit message: This switches Math.log to use an fdlibm based version of log, imported as base::ieee754::log, and use that consistently everywhere, i.e. change the Float64Log TurboFan operators on Intel to use the C++ implementation as well (same for Crankshaft). BUG= Committed: https://crrev.com/2d8738ed09edbdf4d92c5fca96ddfc2d5af22a21 Cr-Commit-Position: refs/heads/master@{#37242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -45 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +18 lines, -12 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +8 lines, -31 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-21 06:18:58 UTC) #2
Weiliang
lgtm lgtm
4 years, 6 months ago (2016-06-24 08:34:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081653005/1
4 years, 6 months ago (2016-06-24 08:36:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 09:04:36 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 09:06:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d8738ed09edbdf4d92c5fca96ddfc2d5af22a21
Cr-Commit-Position: refs/heads/master@{#37242}

Powered by Google App Engine
This is Rietveld 408576698