third_party/WebKit/Source/config.gni - Issue 2081543002: Add gn Blink GC plugin options

Unified Diff: third_party/WebKit/Source/config.gni

Issue 2081543002: Add gn Blink GC plugin options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/config.gni

diff --git a/third_party/WebKit/Source/config.gni b/third_party/WebKit/Source/config.gni

index 17952b739c2dfa6ec60fbbd66189678e3edad957..e90ec1a2be2bc23795b93928a1d6450782449e3f 100644

--- a/third_party/WebKit/Source/config.gni

+++ b/third_party/WebKit/Source/config.gni

@@ -17,6 +17,20 @@ declare_args() {

# garbage-collection infrastructure during compilation.

blink_gc_plugin = true

+ # Set to true to have the clang Blink GC plugin emit class graph (in JSON)

+ # with typed pointer edges; for debugging or other (internal) uses.

+ blink_gc_plugin_option_do_dump_graph = false

Nico 2016/06/21 20:53:13 you can have declare_args in BUILD.gn files, so if

sof 2016/06/22 10:58:04 I've moved the GC plugin ones to Source/BUILD.gn ,

+ # Set to true to have the clang Blink GC plugin additionally check if

+ # a class has an empty destructor which would be unnecessarily invoked

+ # when finalized.

+ blink_gc_plugin_option_warn_unneeded_finalizer = false

+ # Clang plugin installation directory; the default is

+ # to use the build tree "third_party/llvm-build/Release+Asserts/lib"

+ # directory.

+ blink_gc_plugin_lib_path = "//third_party/llvm-build/Release+Asserts/lib/"

Nico 2016/06/21 20:53:13 Hm, the plugin usually only works with clangs buil

sof 2016/06/21 21:12:39 I think it makes sense to broaden the configurable

sof 2016/06/22 10:58:04 Didn't go the whole hog, but added clang_plugin_li

# If true, doesn't compile debug symbols into webcore reducing the

# size of the binary and increasing the speed of gdb.

remove_webcore_debug_symbols = false