Add gn Blink GC plugin options

third_party/WebKit/Source/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("config.gni")
 if (is_clang) {
   import("//build/config/clang/clang.gni")
 }
 
 visibility = [ "//third_party/WebKit/*" ]
@@ skipping 36 matching lines @@
     ]
   }
 
   if (is_win) {
     if (is_component_build) {
       defines += [ "USING_V8_SHARED" ]
     }
   }
 
   if (is_clang && blink_gc_plugin && clang_use_chrome_plugins) {
+    _blink_gc_plugin_dll_extension = "so"
     if (is_mac || is_ios) {
-      cflags += [
-        "-Xclang",
-        "-load",
-        "-Xclang",
-        rebase_path(
-            "//third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib",
-            root_build_dir),
-      ]
-    } else if (is_linux) {
-      cflags += [
-        "-Xclang",
-        "-load",
-        "-Xclang",
-        rebase_path(
-            "//third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.so",
-            root_build_dir),
-      ]
+      _blink_gc_plugin_dll_extension = "dylib"
     }
-
     cflags += [
       "-Xclang",
+      "-load",
+      "-Xclang",
+      rebase_path(
+          "${blink_gc_plugin_lib_path}/libBlinkGCPlugin.${_blink_gc_plugin_dll_extension}",

[Nico, 2016/06/21 20:53:13]

this should only be done if is_mac || is_ios || is_linux (i.e. !is_win -- on
Windows, we compile the plugins into clang.exe itself since the way symbol
visibility works on windows makes "real" clang plugins tricky there)

[sof, 2016/06/22 10:58:04]

Thanks, fixed (the regression.)

+          root_build_dir),
+      "-Xclang",
       "-add-plugin",
       "-Xclang",
       "blink-gc-plugin",
     ]
+
+    # Add arguments for enabled GC plugin options:
+    if (blink_gc_plugin_option_do_dump_graph) {
+      cflags += [
+        "-Xclang",
+        "-plugin-arg-blink-gc-plugin",
+        "-Xclang",
+        "dump-graph",
+      ]
+    }
+    if (blink_gc_plugin_option_warn_unneeded_finalizer) {
+      cflags += [
+        "-Xclang",
+        "-plugin-arg-blink-gc-plugin",
+        "-Xclang",
+        "warn-unneeded-finalizer",
+      ]
+    }
   }
 }
 
 # The follow configs apply to all targets except for unit tests, which rely on
 # static initializers.
 config("non_test_config") {
   cflags = []
 
   if (is_clang) {
     cflags += [ "-Wglobal-constructors" ]
   }
 }
 
 if (is_mac) {
   # This sets up precompiled headers for Mac.
   config("mac_precompiled_headers") {
     precompiled_header = rebase_path("build/mac/Prefix.h", root_build_dir)
     precompiled_source = "//third_party/WebKit/Source/build/mac/Prefix.h"
   }
 }