Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2081523002: Fix clang_use_chrome_plugin for Mac and Skia builds (Closed)

Created:
4 years, 6 months ago by Wei Li
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix clang_use_chrome_plugin for Mac and Skia builds These changes are specific to Mac and Skia builds. They are needed for these builds to compile with clang_use_chrome_plugin. BUG=pdfium:469 Committed: https://pdfium.googlesource.com/pdfium/+/4701fcddeddfef7bccbceaf0f439dee82c3639f0

Patch Set 1 #

Patch Set 2 : changes for skia #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -23 lines) Patch
M core/fxge/apple/apple_int.h View 1 chunk +1 line, -3 lines 0 comments Download
M core/fxge/apple/fx_mac_imp.cpp View 1 chunk +9 lines, -6 lines 0 comments Download
M core/fxge/apple/fx_quartz_device.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M core/fxge/include/fx_ge_apple.h View 1 chunk +5 lines, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device.h View 1 3 chunks +5 lines, -8 lines 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 1 4 chunks +21 lines, -0 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.h View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 33 chunks +48 lines, -0 lines 2 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081523002/20001
4 years, 6 months ago (2016-06-20 16:57:57 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 17:14:22 UTC) #5
Wei Li
for review, thanks
4 years, 6 months ago (2016-06-20 17:26:53 UTC) #7
Lei Zhang
https://codereview.chromium.org/2081523002/diff/20001/xfa/fgas/font/fgas_stdfontmgr.cpp File xfa/fgas/font/fgas_stdfontmgr.cpp (right): https://codereview.chromium.org/2081523002/diff/20001/xfa/fgas/font/fgas_stdfontmgr.cpp#newcode477 xfa/fgas/font/fgas_stdfontmgr.cpp:477: : m_nFaceIndex(0), m_dwFontStyles(0), m_dwUsb(), m_dwCsb() {} Does this actually ...
4 years, 6 months ago (2016-06-20 17:45:02 UTC) #8
Wei Li
https://codereview.chromium.org/2081523002/diff/20001/xfa/fgas/font/fgas_stdfontmgr.cpp File xfa/fgas/font/fgas_stdfontmgr.cpp (right): https://codereview.chromium.org/2081523002/diff/20001/xfa/fgas/font/fgas_stdfontmgr.cpp#newcode477 xfa/fgas/font/fgas_stdfontmgr.cpp:477: : m_nFaceIndex(0), m_dwFontStyles(0), m_dwUsb(), m_dwCsb() {} On 2016/06/20 17:45:02, ...
4 years, 6 months ago (2016-06-20 18:04:10 UTC) #9
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-20 18:20:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081523002/20001
4 years, 6 months ago (2016-06-20 18:41:39 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 18:42:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/4701fcddeddfef7bccbceaf0f439dee82c36...

Powered by Google App Engine
This is Rietveld 408576698