Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: pkg/analysis_server/benchmark/perf/performance_tests.dart

Issue 2081483002: Analysis and completion benchmarks with a set of local uses. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Separate scenarios from actual local benchmarks. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/benchmark/perf/benchmark_scenario.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/benchmark/perf/performance_tests.dart
diff --git a/pkg/analysis_server/benchmark/perf/performance_tests.dart b/pkg/analysis_server/benchmark/perf/performance_tests.dart
index b784c0c04f1008db951687a5c98024cb9671a673..6d301c923303be140c11c2924387bcd2fb19c5d2 100644
--- a/pkg/analysis_server/benchmark/perf/performance_tests.dart
+++ b/pkg/analysis_server/benchmark/perf/performance_tests.dart
@@ -61,13 +61,11 @@ abstract class AbstractAnalysisServerPerformanceTest
Future shutdown() async => await shutdownIfNeeded();
/**
- * Enable [SERVER_STATUS] notifications so that [analysisFinished]
+ * Enable [ServerService.STATUS] notifications so that [analysisFinished]
* can be used.
*/
- Future subscribeToStatusNotifications() {
- List<Future> futures = <Future>[];
- futures.add(sendServerSetSubscriptions([ServerService.STATUS]));
- return Future.wait(futures);
+ Future subscribeToStatusNotifications() async {
+ await sendServerSetSubscriptions([ServerService.STATUS]);
}
}
« no previous file with comments | « pkg/analysis_server/benchmark/perf/benchmark_scenario.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698